Bug 13169 - css-formatted first letter won't hide dynamically
Summary: css-formatted first letter won't hide dynamically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 419.x
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL: http://salokin.de/solutions/firstLett...
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-23 03:51 PDT by Nikolas Bertheau
Modified: 2007-05-24 18:53 PDT (History)
2 users (show)

See Also:


Attachments
First attempt (65.15 KB, patch)
2007-05-17 06:18 PDT, Rob Buis
hyatt: review-
Details | Formatted Diff | Diff
Updated after Hyatts remarks (65.37 KB, patch)
2007-05-18 01:24 PDT, Rob Buis
hyatt: review-
Details | Formatted Diff | Diff
Using usesFirstLetterRules (65.37 KB, patch)
2007-05-18 11:05 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Using usesFirstLetterRules for real (67.58 KB, patch)
2007-05-19 00:50 PDT, Rob Buis
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Bertheau 2007-03-23 03:51:37 PDT
A first letter which has been formatted via CSS won't disappear when the tag is made invisible via Javascript, see reduced example.
Comment 1 Rob Buis 2007-05-17 06:18:51 PDT
Created attachment 14590 [details]
First attempt

This patch should fix the first-letter updating problems when the style changes on the render block.
Cheers,

Rob.
Comment 2 Dave Hyatt 2007-05-17 12:49:58 PDT
Comment on attachment 14590 [details]
First attempt

I don't think asking the document if it is parsing is the appropriate check to make here.  You could just null check the original style (since it will be null if you are having style set for the first time).

I'm a bit nervous about how this will affect perf.
Comment 3 Rob Buis 2007-05-18 01:24:54 PDT
Created attachment 14601 [details]
Updated after Hyatts remarks

I assume this is what Hyatt meant :) I don't have time right now to look into efficiency issues, and it may be hard for me to fix that, so any help is appreciated! (assuming there is an efficienecy problem)
Cheers,

Rob.
Comment 4 mitz 2007-05-18 01:32:23 PDT
Would it be possible and worthwhile to flag just those objects that have first-letters hanging off of their style?
Comment 5 Dave Hyatt 2007-05-18 01:39:48 PDT
Or to have a document()->usesFirstLetterRules (like we have already for firstLine).
Comment 6 Rob Buis 2007-05-18 11:05:16 PDT
Created attachment 14610 [details]
Using usesFirstLetterRules

I used the same approach as usesFirstLineRules...
Cheers,

Rob.
Comment 7 mitz 2007-05-18 11:09:25 PDT
Comment on attachment 14610 [details]
Using usesFirstLetterRules

I think you uploaded the same patch again.
Comment 8 Rob Buis 2007-05-19 00:48:49 PDT
Hi Mitz,

(In reply to comment #7)
> (From update of attachment 14610 [details] [edit])
> I think you uploaded the same patch again.

D'oh. Internal mismanagement, those responsible will be fired :)
Right patch coming up.
Thanks,

Rob.
Comment 9 Rob Buis 2007-05-19 00:50:05 PDT
Created attachment 14620 [details]
Using usesFirstLetterRules for real

This should be the right one.
Cheers,

Rob.
Comment 10 Dave Hyatt 2007-05-24 01:58:59 PDT
Comment on attachment 14620 [details]
Using usesFirstLetterRules for real

r=me
Comment 11 Sam Weinig 2007-05-24 18:53:02 PDT
Landed in r21742.