Bug 120107 - [mips][arm EABI] Fix P_DFGOperation_EJS call in DFG.
Summary: [mips][arm EABI] Fix P_DFGOperation_EJS call in DFG.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-21 00:51 PDT by Julien Brianceau
Modified: 2013-08-22 05:36 PDT (History)
9 users (show)

See Also:

Attachments
Fix P_DFGOperation_EJS call for MIPS and ARM EABI (1.38 KB, patch)
2013-08-21 00:57 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format) (1.39 KB, patch)
2013-08-22 00:43 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-08-21 00:51:42 PDT 
EncodedJSValue parameters must be aligned to even registers for MIPS and ARM EABI.

This constraint is not followed in JITCompiler::Call callOperation(P_DFGOperation_EJS operation, GPRReg result, JSValueRegs value, size_t index) implementation.
Comment 1 Julien Brianceau 2013-08-21 00:57:47 PDT 
Created attachment 209255 [details]
Fix P_DFGOperation_EJS call for MIPS and ARM EABI

Please note that I found this issue by reading the code, but I didn't have time to validate it on a MIPS or ARM environment.
Comment 2 Julien Brianceau 2013-08-22 00:43:42 PDT 
Created attachment 209329 [details]
Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format)
Comment 3 Yong Li 2013-08-22 05:14:47 PDT 
Comment on attachment 209329 [details]
Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format)

looks good to me
Comment 4 WebKit Commit Bot 2013-08-22 05:36:51 PDT 
Comment on attachment 209329 [details]
Fix P_DFGOperation_EJS call for MIPS and ARM EABI (with old fashion ChangeLog format)

Clearing flags on attachment: 209329

Committed r154442: <http://trac.webkit.org/changeset/154442>
Comment 5 WebKit Commit Bot 2013-08-22 05:36:53 PDT 
All reviewed patches have been landed.  Closing bug.