As discussed with Pavel I'm removing FileSystem related code from inspector.
Created attachment 75921 [details] [patch] initial version
Comment on attachment 75921 [details] [patch] initial version Guys, could you provide some context since even those sitting next to you in the same room don't know what are your the plans on this feature?
It sounds like Filesystem API is going to be changed significantly and inspector support as is won't make any sense. Hence, let us nuke it until we know what exactly we want from it.
Created attachment 81825 [details] [PATCH] Proposed change.
Comment on attachment 81825 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=81825&action=review > Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:65 > - DocumentLoader* documentLoader = m_inspectorAgent->inspectedPage()->mainFrame()->loader()->documentLoader(); > - if (documentLoader) { > - ApplicationCacheHost* host = documentLoader->applicationCacheHost(); > + if (m_documentLoader) { > + ApplicationCacheHost* host = m_documentLoader->applicationCacheHost(); What about the lifetime of documentLoader instance? Others looks good to me.
Comment on attachment 81825 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=81825&action=review > Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:64 > + if (m_documentLoader) { Main frame may change on navigation and the loader will change as well. r- for this.
Created attachment 81987 [details] [PATCH] Review comments addressed.
> > What about the lifetime of documentLoader instance? > Good catch, thanks.
Comment on attachment 81987 [details] [PATCH] Review comments addressed. View in context: https://bugs.webkit.org/attachment.cgi?id=81987&action=review > Source/WebCore/inspector/InspectorAgent.cpp:536 > + m_applicationCacheAgent->didCommitLoad(loader); You need to call this for main frame loader only.
Created attachment 81988 [details] [PATCH] Review comments addressed.
Created attachment 81990 [details] [PATCH] Review comments addressed.
Committing to http://svn.webkit.org/repository/webkit/trunk ... D Source/WebCore/inspector/InspectorFileSystemAgent.cpp D Source/WebCore/inspector/InspectorFileSystemAgent.h D Source/WebCore/inspector/front-end/FileSystemView.js M Source/WebCore/CMakeLists.txt M Source/WebCore/ChangeLog M Source/WebCore/GNUmakefile.am M Source/WebCore/WebCore.gypi M Source/WebCore/WebCore.pro M Source/WebCore/WebCore.vcproj/WebCore.vcproj M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/inspector/Inspector.idl M Source/WebCore/inspector/InspectorAgent.cpp M Source/WebCore/inspector/InspectorAgent.h M Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp M Source/WebCore/inspector/InspectorApplicationCacheAgent.h M Source/WebCore/inspector/InspectorInstrumentation.cpp M Source/WebCore/inspector/front-end/ResourcesPanel.js M Source/WebCore/inspector/front-end/Settings.js M Source/WebCore/inspector/front-end/WebKit.qrc M Source/WebCore/inspector/front-end/inspector.html Committed r78234