Summary: | Reformat ProcessThrottler logging | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Rollin <krollin> | ||||
Component: | WebKit Misc. | Assignee: | Keith Rollin <krollin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=205680 https://bugs.webkit.org/show_bug.cgi?id=205683 https://bugs.webkit.org/show_bug.cgi?id=205691 https://bugs.webkit.org/show_bug.cgi?id=205705 https://bugs.webkit.org/show_bug.cgi?id=205869 https://bugs.webkit.org/show_bug.cgi?id=205882 https://bugs.webkit.org/show_bug.cgi?id=205884 https://bugs.webkit.org/show_bug.cgi?id=205984 |
||||||
Attachments: |
|
Description
Keith Rollin
2020-01-01 20:13:13 PST
Created attachment 386594 [details]
Patch
Comment on attachment 386594 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=386594&action=review > Source/WebKit/UIProcess/ProcessThrottler.h:86 > + PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG("invalidate: Ending %{public}s activity / '%{public}s'", Alternatively you could move these implementations to the cpp file and not have new macros named PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG (In reply to Alex Christensen from comment #3) > Alternatively you could move these implementations to the cpp file and not > have new macros named PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG Regardless of where the implementation is, I'd still have PROCESSTHROTTLER_ACTIVITY_RELEASE_LOG, since the point of that macro is to identify that the method is from ProcessThrottler::Activity. The commit-queue encountered the following flaky tests while processing attachment 386594 [details]: highlight/highlight-world-leak.html bug 205643 (author: megan_gardner@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 386594 [details] Patch Clearing flags on attachment: 386594 Committed r253980: <https://trac.webkit.org/changeset/253980> All reviewed patches have been landed. Closing bug. |