Summary: | [WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED() | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=201730 | ||||||||||||||||
Bug Depends on: | 201723, 201475, 201547, 201574, 201590, 201596, 201648, 201691 | ||||||||||||||||
Bug Blocks: | |||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2019-09-06 09:21:43 PDT
Created attachment 378198 [details]
WIP Patch
Created attachment 378263 [details]
WIP Patch
Failures: http/tests/cache-storage/cache-persistency.https.html http/tests/cookies/private-cookie-storage.html http/tests/workers/service/serviceworker-private-browsing.https.html // Bug 201574. imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html http/tests/workers/service/basic-register.html storage/domstorage/localstorage/private-browsing-affects-storage.html // Bug 201547. Created attachment 378440 [details]
WIP Patch
Remaining failures: http/tests/cache-storage/cache-persistency.https.html http/tests/cookies/private-cookie-storage.html Created attachment 378587 [details]
Patch
Created attachment 378588 [details]
Patch
Comment on attachment 378588 [details]
Patch
Looks like I need to update a couple more tests to make iOS-wk2 happy.
*** Bug 201722 has been marked as a duplicate of this bug. *** Created attachment 378647 [details]
Patch
Comment on attachment 378647 [details] Patch Clearing flags on attachment: 378647 Committed r249817: <https://trac.webkit.org/changeset/249817> All reviewed patches have been landed. Closing bug. |