Modern IDB: WebWorker support

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Nolan Lawson]

Created attachment 262769 [details]
Reproducible test case

Inside of a web worker, typeof indexedDB === 'undefined'. Also openDatabase is undefined, although I understand that that's working as intended [1].

I've attached a test case to reproduce. You can also see a live version here: http://bl.ocks.org/nolanlawson/raw/67a02c9395391dc0c11d/

[1]: https://code.google.com/p/chromium/issues/detail?id=434740#c4

Tested on WebKit Nightly, 10601.2.7.1, r190775.

[Brady Eidson]

*** Bug 154129 has been marked as a duplicate of this bug. ***

[Brady Eidson]

Once the patch in https://bugs.webkit.org/show_bug.cgi?id=157398 lands, all that *should* be left is flipping the runtime switch, combined with lots of tests.

That will be done here in this bug.

[Brady Eidson]

<rdar://problem/25605348>

[Brady Eidson]

Created attachment 278574 [details]
Patch

This is a patch to enable IDB-in-workers by default.

Not marking for review yet until after https://bugs.webkit.org/show_bug.cgi?id=157448 is resolved.

[Build Bot]

Comment on attachment 278574 [details]
Patch

Attachment 278574 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1302114

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idb_webworkers.htm
imported/w3c/IndexedDB-private-browsing/idb_webworkers.html

[Build Bot]

Created attachment 278593 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278574 [details]
Patch

Attachment 278574 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1302129

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idb_webworkers.htm
imported/w3c/IndexedDB-private-browsing/idb_webworkers.html

[Build Bot]

Created attachment 278595 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 278574 [details]
Patch

Attachment 278574 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1302132

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idb_webworkers.htm
imported/w3c/IndexedDB-private-browsing/idb_webworkers.html

[Build Bot]

Created attachment 278597 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 278574 [details]
Patch

Attachment 278574 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1302139

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idb_webworkers.htm
imported/w3c/IndexedDB-private-browsing/idb_webworkers.html

[Build Bot]

Created attachment 278598 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Brady Eidson]

Created attachment 278647 [details]
Patch v2

[Brady Eidson]

The build failure on the EWS bots:

/Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCoreTestSupport.build/Objects-normal/i386/JSInternalSettingsGenerated.dia -c /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCoreTestSupport.build/Objects-normal/i386/JSInternalSettingsGenerated.o
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp:2431:10: error: no member named 'setShouldConvertInvalidURLsToBlank' in 'WebCore::InternalSettingsGenerated'
    impl.setShouldConvertInvalidURLsToBlank(WTFMove(shouldConvertInvalidURLsToBlank));

Is *not* related to this patch.

[Alex Christensen]

Comment on attachment 278647 [details]
Patch v2

Hooray!

[Brady Eidson]

http://trac.webkit.org/changeset/200697