Modern IDB: Rework the ownership/RefCounting model of IDBConnectionToServer and IDBConnectionProxy The ConnectionToServer should own its own ConnectionProxy, and ref()'ing the proxy should simply ref() the connection itself.
Created attachment 277070 [details] Patch v1
Comment on attachment 277070 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=277070&action=review > Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp:51 > + m_proxy = std::make_unique<IDBConnectionProxy>(*this); Can't you do this in the initializer list? I feel like e.g. WebPageProxy does.
(In reply to comment #2) > Comment on attachment 277070 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=277070&action=review > > > Source/WebCore/Modules/indexeddb/client/IDBConnectionToServer.cpp:51 > > + m_proxy = std::make_unique<IDBConnectionProxy>(*this); > > Can't you do this in the initializer list? I feel like e.g. WebPageProxy > does. Yah.
Build breakage was due to missing an exported header from WebCore. Fixed. Also, had to reorder one clause in WK2 to make the identifier available at the time the connection is created.
http://trac.webkit.org/changeset/199882