Bug 157289 – Add/refactor isolatedCopy methods for 3 IDB classes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Add/refactor isolatedCopy methods for 3 IDB classes

Needed for upcoming, larger patches.

[Brady Eidson]

Created attachment 277950 [details]
Patch v1

[Build Bot]

Comment on attachment 277950 [details]
Patch v1

Attachment 277950 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1258240

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 277951 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 277950 [details]
Patch v1

Attachment 277950 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1258254

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 277952 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 277950 [details]
Patch v1

Attachment 277950 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1258307

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 277954 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.4

[Build Bot]

Comment on attachment 277950 [details]
Patch v1

Attachment 277950 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1258313

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 277956 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Brady Eidson]

Well those failures are obviously tragic. Building locally.

[Brady Eidson]

Created attachment 277977 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 277977 [details]
Patch for landing

Clearing flags on attachment: 277977

Committed r200372: <http://trac.webkit.org/changeset/200372>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alex Christensen]

Comment on attachment 277977 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=277977&action=review

> Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.cpp:85
> +    destination.m_identifier = source.m_identifier.isolatedCopy();

aha!