Bug 156826 – Modern IDB (Workers): Remove IDBRequest/IDBOpenDBRequest's requirement to get an IDBServerConnection around

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB (Workers): Remove IDBRequest/IDBOpenDBRequest's requirement to get an IDBServerConnection around

This shuffles around how the Connection is accessed and adds some "main thread only" ASSERTs.

This is the first in a series of baby steps removing this dependency from all IDBFoo* objects

[Brady Eidson]

Created attachment 276874 [details]
Patch v1

[Alex Christensen]

Comment on attachment 276874 [details]
Patch v1

r=me.
Do we really need to put "maybe" before the names of all these functions?  Doesn't just the fact that they return a RefPtr instead of a Ref imply that they could return nullptr?

[Brady Eidson]

(In reply to comment #2)
> Comment on attachment 276874 [details]
> Patch v1
> 
> r=me.
> Do we really need to put "maybe" before the names of all these functions? 
> Doesn't just the fact that they return a RefPtr instead of a Ref imply that
> they could return nullptr?

Back in the days before Ref<>, "maybe" denoted "known to possibly fail"

I think it's still common enough that it's worth doing.

But, don't worry - the maybe's will go away and revert back to normal "create" once this code push is done!

[WebKit Commit Bot]

Comment on attachment 276874 [details]
Patch v1

Clearing flags on attachment: 276874

Committed r199804: <http://trac.webkit.org/changeset/199804>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.