Bug 156826 - Modern IDB (Workers): Remove IDBRequest/IDBOpenDBRequest's requirement to get an IDBServerConnection around
Summary: Modern IDB (Workers): Remove IDBRequest/IDBOpenDBRequest's requirement to get...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 149953
  Show dependency tree / graph
 
Reported: 2016-04-20 17:13 PDT by Brady Eidson
Modified: 2016-04-20 21:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (20.14 KB, patch)
2016-04-20 17:20 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-04-20 17:13:56 PDT 
Modern IDB (Workers): Remove IDBRequest/IDBOpenDBRequest's requirement to get an IDBServerConnection around

This shuffles around how the Connection is accessed and adds some "main thread only" ASSERTs.

This is the first in a series of baby steps removing this dependency from all IDBFoo* objects
Comment 1 Brady Eidson 2016-04-20 17:20:19 PDT 
Created attachment 276874 [details]
Patch v1
Comment 2 Alex Christensen 2016-04-20 21:04:49 PDT 
Comment on attachment 276874 [details]
Patch v1

r=me.
Do we really need to put "maybe" before the names of all these functions?  Doesn't just the fact that they return a RefPtr instead of a Ref imply that they could return nullptr?
Comment 3 Brady Eidson 2016-04-20 21:36:51 PDT 
(In reply to comment #2)
> Comment on attachment 276874 [details]
> Patch v1
> 
> r=me.
> Do we really need to put "maybe" before the names of all these functions? 
> Doesn't just the fact that they return a RefPtr instead of a Ref imply that
> they could return nullptr?

Back in the days before Ref<>, "maybe" denoted "known to possibly fail"

I think it's still common enough that it's worth doing.

But, don't worry - the maybe's will go away and revert back to normal "create" once this code push is done!
Comment 4 WebKit Commit Bot 2016-04-20 21:41:59 PDT 
Comment on attachment 276874 [details]
Patch v1

Clearing flags on attachment: 276874

Committed r199804: <http://trac.webkit.org/changeset/199804>
Comment 5 WebKit Commit Bot 2016-04-20 21:42:03 PDT 
All reviewed patches have been landed.  Closing bug.