Bug 156855 - Modern IDB (Workers): More IDBConnectionProxy refactoring
Summary: Modern IDB (Workers): More IDBConnectionProxy refactoring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 149953
  Show dependency tree / graph
 
Reported: 2016-04-21 11:41 PDT by Brady Eidson
Modified: 2016-04-21 14:08 PDT (History)
8 users (show)

See Also:

Attachments
Patch v1 (13.26 KB, patch)
2016-04-21 13:35 PDT, Brady Eidson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-04-21 11:41:37 PDT 
Modern IDB (Workers): More IDBConnectionProxy refactoring
Comment 1 Brady Eidson 2016-04-21 13:35:53 PDT 
Created attachment 276951 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-04-21 13:37:11 PDT 
Attachment 276951 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.h:40:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2016-04-21 13:38:18 PDT 
Style issue fixed locally.
Comment 4 Darin Adler 2016-04-21 13:47:30 PDT 
Comment on attachment 276951 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=276951&action=review

> LayoutTests/ChangeLog:8
> +        * storage/indexeddb/modern/workers-enable-expected.txt: Revert some of the PASS expectations to FAIL, just for now.

Really?
Comment 5 Brady Eidson 2016-04-21 13:57:38 PDT 
(In reply to comment #4)
> Comment on attachment 276951 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=276951&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        * storage/indexeddb/modern/workers-enable-expected.txt: Revert some of the PASS expectations to FAIL, just for now.
> 
> Really?

Yes - It's brand new and in flux, and they'll revert back to PASS in the next couple of patches.
Comment 6 Brady Eidson 2016-04-21 14:08:25 PDT 
http://trac.webkit.org/changeset/199835