Bug 157398 - Modern IDB (Workers): Get everything to the right threads
Summary: Modern IDB (Workers): Get everything to the right threads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on: 157394
Blocks: 149953
  Show dependency tree / graph
 
Reported: 2016-05-05 16:45 PDT by Brady Eidson
Modified: 2016-05-05 20:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch v1 (33.63 KB, patch)
2016-05-05 16:59 PDT, Brady Eidson 		achristensen: review+
Details | Formatted Diff | Diff
Patch for EWS and maybe landing (33.63 KB, patch)
2016-05-05 17:14 PDT, Brady Eidson 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-05-05 16:45:47 PDT 
Modern IDB (Workers): Get everything to the right threads
Comment 1 Brady Eidson 2016-05-05 16:59:55 PDT 
Created attachment 278205 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-05-05 17:01:26 PDT 
Attachment 278205 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/client/IDBConnectionProxy.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2016-05-05 17:14:48 PDT 
Created attachment 278207 [details]
Patch for EWS and maybe landing
Comment 4 WebKit Commit Bot 2016-05-05 19:32:41 PDT 
Comment on attachment 278207 [details]
Patch for EWS and maybe landing

Clearing flags on attachment: 278207

Committed r200503: <http://trac.webkit.org/changeset/200503>
Comment 5 WebKit Commit Bot 2016-05-05 20:30:24 PDT 
Comment on attachment 278207 [details]
Patch for EWS and maybe landing

Rejecting attachment 278207 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 278207, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
LED at 131.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp.rej
patching file Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h
Hunk #1 FAILED at 55.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1274641