Bug 121074

Summary: JSC should have a generational garbage collector
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: NEW ---    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, eflews.bot, gtk-ews, gyuyoung.kim, philn, rego+ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 121239, 126092, 120138, 120179, 120389, 120910, 121007, 121045, 121118, 121238, 121534, 121702, 121821, 121920, 125518, 125530, 125975, 125976, 126012, 126025, 126040, 126047, 126093, 126527, 126552, 126555, 130040, 130617, 131197, 131634    
Bug Blocks:    
Attachments:
Description Flags
checkpoint
none
checkpoint
none
Patch
none
Patch
none
checkpoint
none
checkpoint
none
rebase none

Description Mark Hahnenberg 2013-09-09 20:47:01 PDT
All in the title.
Comment 1 Mark Hahnenberg 2013-09-09 21:17:17 PDT
Created attachment 211152 [details]
checkpoint
Comment 2 Mark Hahnenberg 2013-09-10 17:56:25 PDT
Created attachment 211270 [details]
checkpoint
Comment 3 WebKit Commit Bot 2013-09-10 17:58:26 PDT
Attachment 211270 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/bytecode/ValueProfile.h', u'Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h', u'Source/JavaScriptCore/dfg/DFGCCallHelpers.h', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/dfg/DFGOperations.h', u'Source/JavaScriptCore/dfg/DFGRepatch.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/heap/ConservativeRoots.cpp', u'Source/JavaScriptCore/heap/ConservativeRoots.h', u'Source/JavaScriptCore/heap/CopiedAllocator.h', u'Source/JavaScriptCore/heap/CopiedBlock.h', u'Source/JavaScriptCore/heap/CopiedBlockInlines.h', u'Source/JavaScriptCore/heap/CopiedSpace.cpp', u'Source/JavaScriptCore/heap/CopiedSpace.h', u'Source/JavaScriptCore/heap/CopyVisitorInlines.h', u'Source/JavaScriptCore/heap/Heap.cpp', u'Source/JavaScriptCore/heap/Heap.h', u'Source/JavaScriptCore/heap/MarkedBlock.cpp', u'Source/JavaScriptCore/heap/MarkedBlock.h', u'Source/JavaScriptCore/heap/MarkedSpace.h', u'Source/JavaScriptCore/heap/SlotVisitor.cpp', u'Source/JavaScriptCore/heap/SlotVisitor.h', u'Source/JavaScriptCore/heap/SlotVisitorInlines.h', u'Source/JavaScriptCore/jit/JITInlines.h', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/llint/LLIntCommon.h', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/llint/LLIntSlowPaths.h', u'Source/JavaScriptCore/llint/LowLevelInterpreter64.asm', u'Source/JavaScriptCore/offlineasm/instructions.rb', u'Source/JavaScriptCore/offlineasm/x86.rb', u'Source/JavaScriptCore/runtime/Butterfly.h', u'Source/JavaScriptCore/runtime/ButterflyInlines.h', u'Source/JavaScriptCore/runtime/CommonSlowPaths.cpp', u'Source/JavaScriptCore/runtime/IndexingHeader.h', u'Source/JavaScriptCore/runtime/JSActivation.h', u'Source/JavaScriptCore/runtime/JSArray.cpp', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/JSPropertyNameIterator.h', u'Source/JavaScriptCore/runtime/MapData.cpp', u'Source/JavaScriptCore/runtime/Options.cpp', u'Source/JavaScriptCore/runtime/Structure.cpp', u'Source/JavaScriptCore/runtime/StructureRareDataInlines.h']" exit_code: 1
Source/JavaScriptCore/runtime/JSArray.cpp:703:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/heap/SlotVisitor.cpp:92:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/JSObject.cpp:553:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/JSObject.cpp:2388:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:220:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:222:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.h:97:  The parameter name "cell" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:971:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4494:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/Options.cpp:215:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/Options.cpp:217:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1472:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1504:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1663:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1695:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1700:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/heap/Heap.cpp:506:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:513:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:521:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:529:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:536:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:545:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:553:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:561:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:569:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:578:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:615:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:625:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/heap/Heap.cpp:814:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:820:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:936:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:946:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:2835:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:2837:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:4045:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 36 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Early Warning System Bot 2013-09-10 18:05:18 PDT
Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1731801
Comment 5 Early Warning System Bot 2013-09-10 18:06:09 PDT
Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1726996
Comment 6 EFL EWS Bot 2013-09-10 19:08:46 PDT
Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1731810
Comment 7 EFL EWS Bot 2013-09-10 20:02:45 PDT
Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1784027
Comment 8 kov's GTK+ EWS bot 2013-09-10 23:21:24 PDT
Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1732871
Comment 9 Mark Hahnenberg 2013-09-11 21:37:15 PDT
Created attachment 211394 [details]
Patch
Comment 10 Early Warning System Bot 2013-09-11 21:49:55 PDT
Comment on attachment 211394 [details]
Patch

Attachment 211394 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1802036
Comment 11 Early Warning System Bot 2013-09-11 21:54:31 PDT
Comment on attachment 211394 [details]
Patch

Attachment 211394 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1812038
Comment 12 EFL EWS Bot 2013-09-11 22:03:59 PDT
Comment on attachment 211394 [details]
Patch

Attachment 211394 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1819025
Comment 13 EFL EWS Bot 2013-09-11 22:27:51 PDT
Comment on attachment 211394 [details]
Patch

Attachment 211394 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1859002
Comment 14 Geoffrey Garen 2013-09-11 22:46:51 PDT
Comment on attachment 211394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211394&action=review

Looks like some build carnage remains.

What's the performance status here?

> Source/JavaScriptCore/heap/Heap.cpp:58
> +#define ENABLE_GC_LOGGING 1

Oops!
Comment 15 Mark Hahnenberg 2013-09-12 07:58:10 PDT
(In reply to comment #14)
> (From update of attachment 211394 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211394&action=review
> 
> Looks like some build carnage remains.
> 
> What's the performance status here?
> 
> > Source/JavaScriptCore/heap/Heap.cpp:58
> > +#define ENABLE_GC_LOGGING 1
> 
> Oops!

Sorry, this wasn't meant to be a finished patch :-( Forgot to unset the r+ flag.
Comment 16 Mark Hahnenberg 2013-09-12 07:58:42 PDT
(In reply to comment #15)
>  r+ flag.
r? flag
Comment 17 Mark Hahnenberg 2013-09-17 18:20:42 PDT
Created attachment 211960 [details]
Patch
Comment 18 Early Warning System Bot 2013-09-17 18:30:21 PDT
Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1817954
Comment 19 Early Warning System Bot 2013-09-17 18:32:02 PDT
Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1889045
Comment 20 EFL EWS Bot 2013-09-17 18:43:21 PDT
Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1886291
Comment 21 EFL EWS Bot 2013-09-17 18:46:16 PDT
Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1830092
Comment 22 Build Bot 2013-09-17 18:59:59 PDT
Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1928038
Comment 23 kov's GTK+ EWS bot 2013-09-17 22:27:57 PDT
Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1864216
Comment 24 Mark Hahnenberg 2013-09-19 12:56:17 PDT
Created attachment 212090 [details]
checkpoint
Comment 25 Mark Hahnenberg 2013-09-19 18:56:28 PDT
Created attachment 212115 [details]
checkpoint
Comment 26 Mark Hahnenberg 2013-09-26 17:26:36 PDT
Created attachment 212773 [details]
rebase