Bug 121074 – JSC should have a generational garbage collector

• Component: JavaScriptCore
• Status: NEW

[Mark Hahnenberg]

All in the title.

[Mark Hahnenberg]

Created attachment 211152 [details]
checkpoint

[Mark Hahnenberg]

Created attachment 211270 [details]
checkpoint

[WebKit Commit Bot]

Attachment 211270 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/bytecode/ValueProfile.h', u'Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h', u'Source/JavaScriptCore/dfg/DFGCCallHelpers.h', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/dfg/DFGOperations.h', u'Source/JavaScriptCore/dfg/DFGRepatch.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/heap/ConservativeRoots.cpp', u'Source/JavaScriptCore/heap/ConservativeRoots.h', u'Source/JavaScriptCore/heap/CopiedAllocator.h', u'Source/JavaScriptCore/heap/CopiedBlock.h', u'Source/JavaScriptCore/heap/CopiedBlockInlines.h', u'Source/JavaScriptCore/heap/CopiedSpace.cpp', u'Source/JavaScriptCore/heap/CopiedSpace.h', u'Source/JavaScriptCore/heap/CopyVisitorInlines.h', u'Source/JavaScriptCore/heap/Heap.cpp', u'Source/JavaScriptCore/heap/Heap.h', u'Source/JavaScriptCore/heap/MarkedBlock.cpp', u'Source/JavaScriptCore/heap/MarkedBlock.h', u'Source/JavaScriptCore/heap/MarkedSpace.h', u'Source/JavaScriptCore/heap/SlotVisitor.cpp', u'Source/JavaScriptCore/heap/SlotVisitor.h', u'Source/JavaScriptCore/heap/SlotVisitorInlines.h', u'Source/JavaScriptCore/jit/JITInlines.h', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/jit/JITStubs.h', u'Source/JavaScriptCore/llint/LLIntCommon.h', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/llint/LLIntSlowPaths.h', u'Source/JavaScriptCore/llint/LowLevelInterpreter64.asm', u'Source/JavaScriptCore/offlineasm/instructions.rb', u'Source/JavaScriptCore/offlineasm/x86.rb', u'Source/JavaScriptCore/runtime/Butterfly.h', u'Source/JavaScriptCore/runtime/ButterflyInlines.h', u'Source/JavaScriptCore/runtime/CommonSlowPaths.cpp', u'Source/JavaScriptCore/runtime/IndexingHeader.h', u'Source/JavaScriptCore/runtime/JSActivation.h', u'Source/JavaScriptCore/runtime/JSArray.cpp', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/JSPropertyNameIterator.h', u'Source/JavaScriptCore/runtime/MapData.cpp', u'Source/JavaScriptCore/runtime/Options.cpp', u'Source/JavaScriptCore/runtime/Structure.cpp', u'Source/JavaScriptCore/runtime/StructureRareDataInlines.h']" exit_code: 1
Source/JavaScriptCore/runtime/JSArray.cpp:703:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/heap/SlotVisitor.cpp:92:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/JSObject.cpp:553:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/JSObject.cpp:2388:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:220:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/runtime/CommonSlowPaths.cpp:222:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.h:97:  The parameter name "cell" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:971:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4494:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/Options.cpp:215:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/runtime/Options.cpp:217:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1472:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1504:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1663:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1695:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1700:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/heap/Heap.cpp:506:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:513:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:521:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:529:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:536:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:545:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:553:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:561:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:569:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:578:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:615:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:625:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:779:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/heap/Heap.cpp:814:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:820:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:936:  Should have a space between // and comment  [whitespace/comments] [4]
Source/JavaScriptCore/heap/Heap.cpp:946:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:2835:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:2837:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:4045:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 36 in 50 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1731801

[Early Warning System Bot]

Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1726996

[EFL EWS Bot]

Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1731810

[EFL EWS Bot]

Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1784027

[kov's GTK+ EWS bot]

Comment on attachment 211270 [details]
checkpoint

Attachment 211270 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1732871

[Mark Hahnenberg]

Created attachment 211394 [details]
Patch

[Early Warning System Bot]

Comment on attachment 211394 [details]
Patch

Attachment 211394 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1802036

[Early Warning System Bot]

Comment on attachment 211394 [details]
Patch

Attachment 211394 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1812038

[EFL EWS Bot]

Comment on attachment 211394 [details]
Patch

Attachment 211394 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1819025

[EFL EWS Bot]

Comment on attachment 211394 [details]
Patch

Attachment 211394 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1859002

[Geoffrey Garen]

Comment on attachment 211394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211394&action=review

Looks like some build carnage remains.

What's the performance status here?

> Source/JavaScriptCore/heap/Heap.cpp:58
> +#define ENABLE_GC_LOGGING 1

Oops!

[Mark Hahnenberg]

(In reply to comment #14)
> (From update of attachment 211394 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=211394&action=review
> 
> Looks like some build carnage remains.
> 
> What's the performance status here?
> 
> > Source/JavaScriptCore/heap/Heap.cpp:58
> > +#define ENABLE_GC_LOGGING 1
> 
> Oops!

Sorry, this wasn't meant to be a finished patch :-( Forgot to unset the r+ flag.

[Mark Hahnenberg]

(In reply to comment #15)
>  r+ flag.
r? flag

[Mark Hahnenberg]

Created attachment 211960 [details]
Patch

[Early Warning System Bot]

Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1817954

[Early Warning System Bot]

Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1889045

[EFL EWS Bot]

Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1886291

[EFL EWS Bot]

Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1830092

[Build Bot]

Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1928038

[kov's GTK+ EWS bot]

Comment on attachment 211960 [details]
Patch

Attachment 211960 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1864216

[Mark Hahnenberg]

Created attachment 212090 [details]
checkpoint

[Mark Hahnenberg]

Created attachment 212115 [details]
checkpoint

[Mark Hahnenberg]

Created attachment 212773 [details]
rebase