RESOLVED FIXED Bug 121118
MapData has some issues 
https://bugs.webkit.org/show_bug.cgi?id=121118
Summary MapData has some issues
Mark Hahnenberg
Reported 2013-09-10 13:46:47 PDT
In copyBackingStore, when we reassign the newly copied backing store, we set the capacity to the size in bytes of the backing store. This makes us think we're way bigger than we actually are. Additionally, in visitChildren, we pass the size of the MapData to copyLater(), when we should be passing capacity * sizeof(Entry). I'll add some ASSERTs that should catch this sort of thing in the future.
Attachments
Patch (9.20 KB, patch)
2013-09-10 15:08 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-09-10 15:08:17 PDT
Created attachment 211250 [details] Patch
Geoffrey Garen
Comment 2 2013-09-10 15:13:14 PDT
Comment on attachment 211250 [details] Patch r=me Will the ASSERTs fire in our existing tests, or do we need a new test?
Mark Hahnenberg
Comment 3 2013-09-10 15:13:37 PDT
(In reply to comment #2) > (From update of attachment 211250 [details]) > r=me > > Will the ASSERTs fire in our existing tests, or do we need a new test? They fire in our existing tests.
WebKit Commit Bot
Comment 4 2013-09-10 15:56:22 PDT
Comment on attachment 211250 [details] Patch Clearing flags on attachment: 211250 Committed r155487: <http://trac.webkit.org/changeset/155487>
WebKit Commit Bot
Comment 5 2013-09-10 15:56:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.