RESOLVED FIXED 121534
Rename OperationInProgress to HeapOperation and move it out of Heap.h into its own header 
https://bugs.webkit.org/show_bug.cgi?id=121534
Summary Rename OperationInProgress to HeapOperation and move it out of Heap.h into it...
Mark Hahnenberg
Reported Wednesday, September 18, 2013 5:01:44 AM UTC
OperationInProgress is a silly name. Many parts of the Heap would like to know what HeapOperation is currently underway, but since they are included in Heap.h, they can't directly reference HeapOperation if it lives in Heap.h. The simplest thing to do is to give HeapOperation its own header. While a bit overkill, it simplifies including it wherever its needed.
Attachments
Patch (13.06 KB, patch)
2013-09-17 21:03 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (15.35 KB, patch)
2013-09-17 21:07 PDT, Mark Hahnenberg 		ggaren: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 Wednesday, September 18, 2013 5:03:24 AM UTC
Created attachment 211968 [details] Patch
Mark Hahnenberg
Comment 2 Wednesday, September 18, 2013 5:07:45 AM UTC
Created attachment 211970 [details] Patch
Geoffrey Garen
Comment 3 Wednesday, September 18, 2013 5:34:03 AM UTC
Comment on attachment 211970 [details] Patch r=me
Build Bot
Comment 4 Wednesday, September 18, 2013 5:35:26 AM UTC
Comment on attachment 211970 [details] Patch Attachment 211970 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1900085
Build Bot
Comment 5 Wednesday, September 18, 2013 5:51:15 AM UTC
Comment on attachment 211970 [details] Patch Attachment 211970 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1900086
Mark Hahnenberg
Comment 6 Wednesday, September 18, 2013 6:26:03 PM UTC
Committed r156050: <http://trac.webkit.org/changeset/156050>
Note You need to log in before you can comment on or make changes to this bug.