Bug 121920 - op_to_this shouldn't use value profiling
Summary: op_to_this shouldn't use value profiling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 121074
  Show dependency tree / graph
 
Reported: 2013-09-25 13:06 PDT by Mark Hahnenberg
Modified: 2013-10-02 11:27 PDT (History)
2 users (show)

See Also:

Attachments
Patch (22.84 KB, patch)
2013-09-25 14:10 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-09-25 13:06:34 PDT 
Currently it's the only opcode that uses m_singletonValue, which is unnecessary. Our current plan is to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables during nursery collections.
Comment 1 Mark Hahnenberg 2013-09-25 14:10:36 PDT 
Created attachment 212624 [details]
Patch
Comment 2 Geoffrey Garen 2013-09-25 17:55:01 PDT 
Comment on attachment 212624 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-09-26 10:15:37 PDT 
Comment on attachment 212624 [details]
Patch

Clearing flags on attachment: 212624

Committed r156468: <http://trac.webkit.org/changeset/156468>
Comment 4 WebKit Commit Bot 2013-09-26 10:15:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Filip Pizlo 2013-10-01 20:14:06 PDT 
This caused a 5-9% regression on V8Spider/deltablue.
Comment 6 Mark Hahnenberg 2013-10-02 09:26:25 PDT 
(In reply to comment #5)
> This caused a 5-9% regression on V8Spider/deltablue.

According to whom? I ran benchmarks before landing.
Comment 7 Filip Pizlo 2013-10-02 11:27:16 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > This caused a 5-9% regression on V8Spider/deltablue.
> 
> According to whom? I ran benchmarks before landing.

According to my Mac Pro.