WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121821
op_get_callee shouldn't use value profiling
https://bugs.webkit.org/show_bug.cgi?id=121821
Summary
op_get_callee shouldn't use value profiling
Mark Hahnenberg
Reported
2013-09-23 20:01:48 PDT
Currently it's one of the two opcodes that uses m_singletonValue, which is unnecessary. Our current plan is to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables during nursery collections.
Attachments
Patch
(12.72 KB, patch)
2013-09-24 14:44 PDT
,
Mark Hahnenberg
fpizlo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2013-09-24 14:44:50 PDT
Created
attachment 212507
[details]
Patch
Filip Pizlo
Comment 2
2013-09-24 14:47:27 PDT
Comment on
attachment 212507
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=212507&action=review
r=me
> Source/JavaScriptCore/runtime/Options.cpp:215 > - > +
Revert.
Mark Hahnenberg
Comment 3
2013-09-24 17:36:47 PDT
Committed
r156376
: <
http://trac.webkit.org/changeset/156376
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug