Bug 121821 - op_get_callee shouldn't use value profiling
Summary: op_get_callee shouldn't use value profiling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 121074
  Show dependency tree / graph
 
Reported: 2013-09-23 20:01 PDT by Mark Hahnenberg
Modified: 2013-09-24 17:36 PDT (History)
0 users

See Also:

Attachments
Patch (12.72 KB, patch)
2013-09-24 14:44 PDT, Mark Hahnenberg 		fpizlo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-09-23 20:01:48 PDT 
Currently it's one of the two opcodes that uses m_singletonValue, which is unnecessary. Our current plan is to remove m_singletonValue so that GenGC can have a simpler story for handling CodeBlocks/FunctionExecutables during nursery collections.
Comment 1 Mark Hahnenberg 2013-09-24 14:44:50 PDT 
Created attachment 212507 [details]
Patch
Comment 2 Filip Pizlo 2013-09-24 14:47:27 PDT 
Comment on attachment 212507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212507&action=review

r=me

> Source/JavaScriptCore/runtime/Options.cpp:215
> -    
> +

Revert.
Comment 3 Mark Hahnenberg 2013-09-24 17:36:47 PDT 
Committed r156376: <http://trac.webkit.org/changeset/156376>