Bug 120138 - Rename/refactor setButterfly/setStructure
Summary: Rename/refactor setButterfly/setStructure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 121074
  Show dependency tree / graph
 
Reported: 2013-08-21 15:15 PDT by Mark Hahnenberg
Modified: 2013-09-12 10:58 PDT (History)
0 users

See Also:

Attachments
Patch (17.84 KB, patch)
2013-08-21 15:17 PDT, Mark Hahnenberg 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-08-21 15:15:24 PDT 
setButterfly -> setStructureAndButterfly (which is actually what it does)
setStructure(VM&, Structure*, Butterfly*) -> setStructure(VM&, Structure*) and doesn't implicitly assign to the Butterfly.
Comment 1 Mark Hahnenberg 2013-08-21 15:17:31 PDT 
Created attachment 209306 [details]
Patch
Comment 2 Geoffrey Garen 2013-08-21 16:06:35 PDT 
Comment on attachment 209306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209306&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +        used m_structure internally since that's what every single client of setStructure

I think you mean "used m_butterfly".
Comment 3 Mark Hahnenberg 2013-08-21 16:22:06 PDT 
Committed r154426: <http://trac.webkit.org/changeset/154426>