WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120138
Rename/refactor setButterfly/setStructure
https://bugs.webkit.org/show_bug.cgi?id=120138
Summary
Rename/refactor setButterfly/setStructure
Mark Hahnenberg
Reported
2013-08-21 15:15:24 PDT
setButterfly -> setStructureAndButterfly (which is actually what it does) setStructure(VM&, Structure*, Butterfly*) -> setStructure(VM&, Structure*) and doesn't implicitly assign to the Butterfly.
Attachments
Patch
(17.84 KB, patch)
2013-08-21 15:17 PDT
,
Mark Hahnenberg
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2013-08-21 15:17:31 PDT
Created
attachment 209306
[details]
Patch
Geoffrey Garen
Comment 2
2013-08-21 16:06:35 PDT
Comment on
attachment 209306
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=209306&action=review
r=me
> Source/JavaScriptCore/ChangeLog:11 > + used m_structure internally since that's what every single client of setStructure
I think you mean "used m_butterfly".
Mark Hahnenberg
Comment 3
2013-08-21 16:22:06 PDT
Committed
r154426
: <
http://trac.webkit.org/changeset/154426
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug