| Summary: | Get rid of multiple inheritance support from the bindings generators | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||||||||
| Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | ap, benjamin, buildbot, commit-queue, d-r, esprehn+autocc, fmalita, ggaren, gyuyoung.kim, haraken, jberlin, kangil.han, laszlo.gombos, pdr, rniwa, schenney, thorton | ||||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| URL: | http://www.w3.org/TR/WebIDL/#idl-interfaces | ||||||||||||||||||||||||||
| Bug Depends on: | 117785, 118014, 118029, 118142, 118170, 118178, 118305, 118349, 118351, 161897 | ||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Chris Dumez
2013-07-03 04:35:32 PDT
Created attachment 206448 [details]
Patch
Comment on attachment 206448 [details]
Patch
This looks great. Thanks for doing this.
Comment on attachment 206448 [details] Patch Attachment 206448 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1051216 Comment on attachment 206448 [details] Patch Attachment 206448 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/936603 Hmm, mac port uses multiple inheritance at least in one place:
] interface Node
#if defined(LANGUAGE_OBJECTIVE_C) && LANGUAGE_OBJECTIVE_C
: Object, EventTarget
#endif /* defined(LANGUAGE_OBJECTIVE_C) */
{
I need to investigate how to solve this.
Created attachment 206461 [details]
Test for mac ews
Comment on attachment 206461 [details] Test for mac ews Attachment 206461 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1059085 Comment on attachment 206461 [details] Test for mac ews Attachment 206461 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/954899 Created attachment 206510 [details]
Another test for mac-ews
Comment on attachment 206510 [details] Another test for mac-ews Attachment 206510 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/973967 Comment on attachment 206510 [details] Another test for mac-ews Attachment 206510 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/973968 Created attachment 206531 [details]
Another test for mac-ews
Comment on attachment 206531 [details] Another test for mac-ews Attachment 206531 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1045283 Comment on attachment 206531 [details] Another test for mac-ews Attachment 206531 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1063104 Created attachment 206540 [details]
Another test for mac-ews
Comment on attachment 206540 [details] Another test for mac-ews Attachment 206540 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1064101 Comment on attachment 206540 [details] Another test for mac-ews Attachment 206540 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1054317 Created attachment 206730 [details]
Another test for mac-ews
Comment on attachment 206730 [details] Another test for mac-ews Attachment 206730 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1084114 Comment on attachment 206730 [details] Another test for mac-ews Attachment 206730 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1086088 Created attachment 206754 [details]
Another test for mac-ews
Comment on attachment 206754 [details] Another test for mac-ews Attachment 206754 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1089169 Comment on attachment 206754 [details] Another test for mac-ews Attachment 206754 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1085179 Created attachment 206766 [details]
Another test for mac-ews
Created attachment 206769 [details]
Patch
@haraken: Could you please take another look? I had to take a more conservative approach and keep supporting multiple inheritance in the IDL parser. Unfortunately, the ObjC bindings generator still relies on multiple inheritance for the Node interface and I don't understand those bindings enough to fix the issue :/ Comment on attachment 206769 [details]
Patch
OK, lgtm. Landing easy parts first makes sense.
Created attachment 206777 [details]
Patch for landing
Comment on attachment 206777 [details] Patch for landing Rejecting attachment 206777 [details] from commit-queue. New failing tests: compositing/reflections/load-video-in-reflection.html Full output: http://webkit-queues.appspot.com/results/1086187 Created attachment 206780 [details]
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Comment on attachment 206777 [details]
Patch for landing
Failure is unrelated, cq+ again.
Comment on attachment 206777 [details] Patch for landing Clearing flags on attachment: 206777 Committed r152725: <http://trac.webkit.org/changeset/152725> All reviewed patches have been landed. Closing bug. |