Bug 99705 – [GTK] Use custom private macros to define GObjects

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

We can reduce the GObject boilerplate and hide the placement new syntax that causes some confusion.

[Carlos Garcia Campos]

Created attachment 169389 [details]
Patch

This patch should be applied on top of the C API migration ones. It removes ~350 lines of GObject boilerplate.

[Carlos Garcia Campos]

Created attachment 169422 [details]
Updated patch

Patch updated just to apply on top of patch attached to bug #99724

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Review Bot]

Attachment 169422 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:46:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:47:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:69:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:70:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:106:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:107:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:108:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:109:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:110:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:111:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:112:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:128:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 12 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 169422 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169422&action=review

Nice work, but until we establish an exception for GTK code for code indenting, I think we should just follow the style rules. 

>> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:47
>> +WEBKIT_DEFINE_TYPE_WITH_CODE(WebKitGeolocationPermissionRequest, webkit_geolocation_permission_request, G_TYPE_OBJECT,
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Please follow the style rule here.

>> Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:69
>> +#define WEBKIT_DEFINE_TYPE(TN, t_n, T_P) _WEBKIT_DEFINE_TYPE_EXTENDED(TN, t_n, T_P, 0, {})
> 
> Missing space inside { }.  [whitespace/braces] [5]

Instead of using variable names like TN, t_n and T_P they should be real words, I think.

> Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:74
> +#define _WEBKIT_DEFINE_TYPE_EXTENDED_BEGIN(TypeName, type_name, TYPE_PARENT, flags) \

Instead of using TypeName, type_name, TYPE_PARENT, how about typeName, underscoredTypeName, parentType, flags?

>> Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h:106
>> +                                          g_intern_static_string(#TypeName), \
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

Please follow the style rule here as well.

[Carlos Garcia Campos]

WebKitPrivate.h should probably just be ignored by the style checker, I can include that in the patch.

[Carlos Garcia Campos]

Created attachment 175652 [details]
Updated patch

Managed to work around all the style "issues"

[Carlos Garcia Campos]

Committed r135565: <http://trac.webkit.org/changeset/135565>