RESOLVED FIXED Bug 96784
[GTK] Don't use the C API internally in WebKitSettings 
https://bugs.webkit.org/show_bug.cgi?id=96784
Summary [GTK] Don't use the C API internally in WebKitSettings
Carlos Garcia Campos
Reported 2012-09-14 07:30:12 PDT
Use the C++ classes instead.
Attachments
Patch (50.66 KB, patch)
2012-09-14 07:31 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch to apply on current git master (51.12 KB, patch)
2012-10-01 08:46 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch to build on current git master (52.17 KB, patch)
2012-10-16 01:45 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-09-14 07:31:34 PDT
Created attachment 164149 [details] Patch
Carlos Garcia Campos
Comment 2 2012-10-01 08:46:08 PDT
Created attachment 166484 [details] Updated patch to apply on current git master A patch in trunk broke this one
WebKit Review Bot
Comment 3 2012-10-01 08:49:55 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Mario Sanchez Prada
Comment 4 2012-10-03 02:04:00 PDT
Comment on attachment 166484 [details] Updated patch to apply on current git master View in context: https://bugs.webkit.org/attachment.cgi?id=166484&action=review Looks good to me! > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:956 > + * WebKitSettings:media-playback-allows-inline: Haha... good catch, "vigilante"!
Carlos Garcia Campos
Comment 5 2012-10-16 01:45:06 PDT
Created attachment 168891 [details] Updated patch to build on current git master Updated after smooth-scrolling setting
Gustavo Noronha (kov)
Comment 6 2012-10-18 06:25:55 PDT
Comment on attachment 168891 [details] Updated patch to build on current git master View in context: https://bugs.webkit.org/attachment.cgi?id=168891&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:-1105 > - ASSERT(!priv->userAgent.isNull()); Shouldn't you keep the ASSERT?
Carlos Garcia Campos
Comment 7 2012-10-18 06:32:42 PDT
Comment on attachment 168891 [details] Updated patch to build on current git master View in context: https://bugs.webkit.org/attachment.cgi?id=168891&action=review >> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:-1105 >> - ASSERT(!priv->userAgent.isNull()); > > Shouldn't you keep the ASSERT? I think it's impossible to happen, user-agent is a construct property, and when passing NULL it's initialized to the default user agent, so at this point, if we have a valid a WebKitSettings object, userAgent can't be NULL.
Carlos Garcia Campos
Comment 8 2012-10-18 07:49:39 PDT
Committed r131750: <http://trac.webkit.org/changeset/131750>
Note You need to log in before you can comment on or make changes to this bug.