Bug 96784 - [GTK] Don't use the C API internally in WebKitSettings
Summary: [GTK] Don't use the C API internally in WebKitSettings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 96783
Blocks: 96766 96785 99705
  Show dependency tree / graph
 
Reported: 2012-09-14 07:30 PDT by Carlos Garcia Campos
Modified: 2012-10-18 07:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch (50.66 KB, patch)
2012-09-14 07:31 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch to apply on current git master (51.12 KB, patch)
2012-10-01 08:46 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch to build on current git master (52.17 KB, patch)
2012-10-16 01:45 PDT, Carlos Garcia Campos 		gustavo: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-09-14 07:30:12 PDT 
Use the C++ classes instead.
Comment 1 Carlos Garcia Campos 2012-09-14 07:31:34 PDT 
Created attachment 164149 [details]
Patch
Comment 2 Carlos Garcia Campos 2012-10-01 08:46:08 PDT 
Created attachment 166484 [details]
Updated patch to apply on current git master

A patch in trunk broke this one
Comment 3 WebKit Review Bot 2012-10-01 08:49:55 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Mario Sanchez Prada 2012-10-03 02:04:00 PDT 
Comment on attachment 166484 [details]
Updated patch to apply on current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=166484&action=review

Looks good to me!

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:956
> +     * WebKitSettings:media-playback-allows-inline:

Haha... good catch, "vigilante"!
Comment 5 Carlos Garcia Campos 2012-10-16 01:45:06 PDT 
Created attachment 168891 [details]
Updated patch to build on current git master

Updated after smooth-scrolling setting
Comment 6 Gustavo Noronha (kov) 2012-10-18 06:25:55 PDT 
Comment on attachment 168891 [details]
Updated patch to build on current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=168891&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:-1105
> -    ASSERT(!priv->userAgent.isNull());

Shouldn't you keep the ASSERT?
Comment 7 Carlos Garcia Campos 2012-10-18 06:32:42 PDT 
Comment on attachment 168891 [details]
Updated patch to build on current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=168891&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:-1105
>> -    ASSERT(!priv->userAgent.isNull());
> 
> Shouldn't you keep the ASSERT?

I think it's impossible to happen, user-agent is a construct property, and when passing NULL it's initialized to the default user agent, so at this point, if we have a valid a WebKitSettings object, userAgent can't be NULL.
Comment 8 Carlos Garcia Campos 2012-10-18 07:49:39 PDT 
Committed r131750: <http://trac.webkit.org/changeset/131750>