RESOLVED FIXED 96774
[GTK] Don't use the C API internally in WebKitFileChooserRequest 
https://bugs.webkit.org/show_bug.cgi?id=96774
Summary [GTK] Don't use the C API internally in WebKitFileChooserRequest
Carlos Garcia Campos
Reported 2012-09-14 06:58:55 PDT
Use the C++ classes instead.
Attachments
Patch (10.31 KB, patch)
2012-09-14 07:00 PDT, Carlos Garcia Campos 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2012-09-14 07:00:13 PDT
Created attachment 164134 [details] Patch
WebKit Review Bot
Comment 2 2012-09-14 07:03:06 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Mario Sanchez Prada
Comment 3 2012-10-03 01:38:17 PDT
Comment on attachment 164134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164134&action=review Looks good to me. I just have a really minor comment > Source/WebKit2/UIProcess/API/gtk/WebKitFileChooserRequest.cpp:255 > + if (!mimeTypes->size()) Why not using the numOfMimeTypes variable here? I know it's not crucial stuff, but you will need to call mimeTypes->size() again below, so it might be handy
Xan Lopez
Comment 4 2012-10-18 08:41:11 PDT
Comment on attachment 164134 [details] Patch As Mario says there's a couple of places where keeping the num variable makes sense, but not really a big deal. Looks good otherwise.
Carlos Garcia Campos
Comment 5 2012-10-18 08:53:07 PDT
(In reply to comment #4) > (From update of attachment 164134 [details]) > As Mario says there's a couple of places where keeping the num variable makes sense, but not really a big deal. Looks good otherwise. Sure, I'll change that before landing.
Carlos Garcia Campos
Comment 6 2012-10-18 08:55:37 PDT
Committed r131757: <http://trac.webkit.org/changeset/131757>
Note You need to log in before you can comment on or make changes to this bug.