Bug 96777 - [GTK] Don't use the C API internally in WebKitFormSubmissionRequest
Summary: [GTK] Don't use the C API internally in WebKitFormSubmissionRequest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 96775
Blocks: 96766 96778 99705
  Show dependency treegraph
 
Reported: 2012-09-14 07:04 PDT by Carlos Garcia Campos
Modified: 2012-10-18 08:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.25 KB, patch)
2012-09-14 07:06 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch updated to build on current git master (6.29 KB, patch)
2012-10-16 01:33 PDT, Carlos Garcia Campos
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-09-14 07:04:53 PDT
Use the C++ classes instead.
Comment 1 Carlos Garcia Campos 2012-09-14 07:06:30 PDT
Created attachment 164137 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-14 07:10:46 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Mario Sanchez Prada 2012-10-03 01:42:22 PDT
Comment on attachment 164137 [details]
Patch

Nothing to comment. Looks good to me
Comment 4 Carlos Garcia Campos 2012-10-16 01:33:56 PDT
Created attachment 168889 [details]
Patch updated to build on current git master

Updated patch after the hash map first/second rename
Comment 5 Xan Lopez 2012-10-18 04:51:52 PDT
Comment on attachment 168889 [details]
Patch updated to build on current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=168889&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:26
> +using namespace WebKit;

I believe the coding style advises against this kind of thing, see the section about the 'using' directive. So not sure if you are just missing some include here or need to qualify the types directly.
Comment 6 Carlos Garcia Campos 2012-10-18 05:00:08 PDT
(In reply to comment #5)
> (From update of attachment 168889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168889&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:26
> > +using namespace WebKit;
> 
> I believe the coding style advises against this kind of thing, see the section about the 'using' directive. So not sure if you are just missing some include here or need to qualify the types directly.

Yes, you are right, I already agreed with Martin to fix all of those in one step once all the patches have landed.
Comment 7 Xan Lopez 2012-10-18 08:28:54 PDT
Comment on attachment 168889 [details]
Patch updated to build on current git master

Looks good then.
Comment 8 Carlos Garcia Campos 2012-10-18 08:49:31 PDT
Committed r131756: <http://trac.webkit.org/changeset/131756>