Bug 96777 – [GTK] Don't use the C API internally in WebKitFormSubmissionRequest

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

Use the C++ classes instead.

[Carlos Garcia Campos]

Created attachment 164137 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Mario Sanchez Prada]

Comment on attachment 164137 [details]
Patch

Nothing to comment. Looks good to me

[Carlos Garcia Campos]

Created attachment 168889 [details]
Patch updated to build on current git master

Updated patch after the hash map first/second rename

[Xan Lopez]

Comment on attachment 168889 [details]
Patch updated to build on current git master

View in context: https://bugs.webkit.org/attachment.cgi?id=168889&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:26
> +using namespace WebKit;

I believe the coding style advises against this kind of thing, see the section about the 'using' directive. So not sure if you are just missing some include here or need to qualify the types directly.

[Carlos Garcia Campos]

(In reply to comment #5)
> (From update of attachment 168889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=168889&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitFormSubmissionRequestPrivate.h:26
> > +using namespace WebKit;
> 
> I believe the coding style advises against this kind of thing, see the section about the 'using' directive. So not sure if you are just missing some include here or need to qualify the types directly.

Yes, you are right, I already agreed with Martin to fix all of those in one step once all the patches have landed.

[Xan Lopez]

Comment on attachment 168889 [details]
Patch updated to build on current git master

Looks good then.

[Carlos Garcia Campos]

Committed r131756: <http://trac.webkit.org/changeset/131756>