Bug 96778 - [GTK] Don't use the C API internally in WebKitGeolocation classes
Summary: [GTK] Don't use the C API internally in WebKitGeolocation classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 96777
Blocks: 96766 96779
  Show dependency tree / graph
 
Reported: 2012-09-14 07:09 PDT by Carlos Garcia Campos
Modified: 2012-10-17 08:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.98 KB, patch)
2012-09-14 07:10 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Updated patch to build on current git master (11.08 KB, patch)
2012-10-16 01:38 PDT, Carlos Garcia Campos 		gustavo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-09-14 07:09:00 PDT 
Use the C++ classes instead.
Comment 1 Carlos Garcia Campos 2012-09-14 07:10:26 PDT 
Created attachment 164139 [details]
Patch
Comment 2 Mario Sanchez Prada 2012-10-03 01:44:15 PDT 
Comment on attachment 164139 [details]
Patch

Looks good to me
Comment 3 Carlos Garcia Campos 2012-10-16 01:38:39 PDT 
Created attachment 168890 [details]
Updated patch to build on current git master

Updated after WebGeolocationPosition::create() API change
Comment 4 Rik Cabanier 2012-10-16 08:46:27 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 Carlos Garcia Campos 2012-10-17 08:24:31 PDT 
Committed r131598: <http://trac.webkit.org/changeset/131598>