Bug 96781 - [GTK] Don't use the C API internally in PolicyClient classes
Summary: [GTK] Don't use the C API internally in PolicyClient classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on: 96780
Blocks: 96766 96782 99705
  Show dependency treegraph
 
Reported: 2012-09-14 07:21 PDT by Carlos Garcia Campos
Modified: 2012-10-18 05:22 PDT (History)
4 users (show)

See Also:


Attachments
Patch (19.29 KB, patch)
2012-09-14 07:22 PDT, Carlos Garcia Campos
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-09-14 07:21:23 PDT
Use the C++ classes instead.
Comment 1 Carlos Garcia Campos 2012-09-14 07:22:37 PDT
Created attachment 164144 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-14 07:26:29 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Mario Sanchez Prada 2012-10-03 02:08:05 PDT
Comment on attachment 164144 [details]
Patch

Looks good to me
Comment 4 Xan Lopez 2012-10-18 05:09:54 PDT
Comment on attachment 164144 [details]
Patch

Yeah, looks good. Same comment about the header stuff.
Comment 5 Carlos Garcia Campos 2012-10-18 05:22:51 PDT
Committed r131731: <http://trac.webkit.org/changeset/131731>