88970 – [Form] Multiple fields time input UI

RESOLVED FIXED 88970

[Form] Multiple fields time input UI

https://bugs.webkit.org/show_bug.cgi?id=88970

Summary [Form] Multiple fields time input UI

yosin

Reported 2012-06-13 00:16:18 PDT

This is one of UI for input type "time" using fields for each time parts, e.g. hour, minute, second, millisecond.

Attachments
Patch 1 - WIP (22.25 KB, patch) 2012-06-13 00:27 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 2 - WIP (50.89 KB, patch) 2012-06-13 00:35 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 3 - Code Complete (85.03 KB, patch) 2012-06-25 03:38 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 4 - Code Complete (108.79 KB, patch) 2012-06-26 02:42 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 5 - Code Complete (59.80 KB, patch) 2012-07-11 01:28 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 6 (66.61 KB, patch) 2012-07-31 00:50 PDT, yosin	tkent: review- yosin: commit-queue-	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

yosin

Comment 1 2012-06-13 00:27:32 PDT

Created attachment 147250 [details] Patch 1 - WIP

yosin

Comment 2 2012-06-13 00:35:35 PDT

Created attachment 147253 [details] Patch 2 - WIP

yosin

Comment 3 2012-06-25 03:38:54 PDT

Created attachment 149269 [details] Patch 3 - Code Complete

yosin

Comment 4 2012-06-26 02:42:16 PDT

Created attachment 149496 [details] Patch 4 - Code Complete

Kent Tamura

Comment 5 2012-06-26 18:34:05 PDT

Because you'll add new ENABLE flag, you had better announce it and your plan to webkit-dev.

yosin

Comment 6 2012-07-11 01:28:57 PDT

Created attachment 151641 [details] Patch 5 - Code Complete

yosin

Comment 7 2012-07-31 00:50:49 PDT

Created attachment 155459 [details] Patch 6

yosin

Comment 8 2012-07-31 00:54:43 PDT

Comment on attachment 155459 [details] Patch 6 Could you review this patch? Tests will be uploaded into another bug for reducing size of patch. ChangeLogs isn't incomplete. Thanks in advance.

WebKit Review Bot

Comment 9 2012-07-31 01:26:06 PDT

Comment on attachment 155459 [details] Patch 6 Attachment 155459 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13385816

Kent Tamura

Comment 10 2012-07-31 02:45:46 PDT

Comment on attachment 155459 [details] Patch 6 View in context: https://bugs.webkit.org/attachment.cgi?id=155459&action=review Ok, I agree with the design and the rough structure. Let's split this into multiple patches like: 1. Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS and touch source files with ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS) (Only DateTimeFormat.h?) 2. WebCore/css/html.css part 3. WebCore/html/shadow/ part 4. WebCore/html/ part 5. RuntimeEnabledFeatures.cpp part > Source/WebCore/html/shadow/DateTimeFieldElements.h:88 > +class DateTimeNumericFieldElement : public DateTimeFieldElement { Please make its own source files. This class is not small. > Source/WebCore/html/shadow/DateTimeFieldElements.h:136 > +class DateTimeHourFieldElement : public DateTimeNumericFieldElement { ditto. > Source/WebCore/html/shadow/DateTimeFieldElements.h:153 > +class DateTimeSymbolicFieldElement : public DateTimeFieldElement { ditto.

yosin

Comment 11 2012-08-19 18:22:09 PDT

Multiple fields time input UI is enabled for Chromium port, except for Android: http://trac.webkit.org/changeset/125868

Note You need to log in before you can comment on or make changes to this bug.