Bug 92822 - [Chromium] Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
Summary: [Chromium] Enable ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 88970
  Show dependency tree / graph
 
Reported: 2012-07-31 18:55 PDT by yosin
Modified: 2012-07-31 20:29 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (5.12 KB, patch)
2012-07-31 19:28 PDT, yosin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-07-31 18:55:57 PDT 
This bug is one of preparation of landing multiple fields time UI for input type "time".

Enabling ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS makes sure DateTimeFormat related functions, localizedTimeFormatText(), localizedShortTimeFormatText() and 
timeAMPMLabels(), built without failure.
Comment 1 yosin 2012-07-31 19:09:40 PDT 
Enabling ENABLE_INPUT_TYPE_MULTIPLE_FIELDS also adds localizedDecimalSeparator().


Following files have ENABLE_INPUT_TYPE_MULTIPLE_FIELDS

Source/WebCore/platform/text/DateTimeFormat.h
  class DateTimeFormat
Source/WebCore/platform/text/LocalizedNumber.h
  localizedDecimalSeparator()
Source/WebCore/platform/text/LocalizedDate.h
  localizedTimeFormatText(), localizedShortTimeFormatText() and 
timeAMPMLabels()
Source/WebCore/platform/text/LocaleWin.cpp
  include DateTimeFormat.h
Source/WebCore/platform/text/LocalizedDateWin.cpp
  include LocalizedDate.h
Source/WebCore/platform/text/DateTimeFormat.cpp
  include DateTimeFormat.h
Source/WebCore/platform/text/LocalizedNumberICU.cpp
  include LocalizedNumber.h
  include LocaleICU.h
Source/WebCore/platform/text/LocalizedNumberNone.cpp
  include LocalizedNumber.h
Source/WebCore/platform/text/LocalizedDateICU.cpp
  include LocalizedDate.h
  include LocaleICU.h
Source/WebCore/platform/text/LocaleICU.h
Source/WebCore/platform/text/LocaleWin.h
Source/WebCore/platform/text/mac/LocalizedDateMac.cpp
  include LocalizedDate.h
Source/WebCore/platform/text/mac/LocaleMac.h
Source/WebCore/platform/text/mac/LocaleMac.mm
  include LocalizedDate.h
Source/WebCore/platform/text/mac/LocalizedNumberMac.mm
  include LocalizedNumber.h
Source/WebCore/platform/text/LocaleICU.cpp
  include LocaleICU.h
Source/WebKit/chromium/tests/DateTimeFormatTest.cpp
  include DateTimeFormat.h
Source/WebKit/chromium/tests/LocalizedDateICUTest.cpp
  include LocaleICU.h
Source/WebKit/chromium/tests/LocaleMacTest.cpp
  include LocaleMac.h
Source/WebKit/chromium/tests/LocaleWinTest.cpp
  include LocaleWin.h
Source/WebKit/chromium/tests/LocalizedNumberICUTest.cpp
  include LocaleICU.h
Comment 2 yosin 2012-07-31 19:28:58 PDT 
Created attachment 155704 [details]
Patch 1
Comment 3 yosin 2012-07-31 19:29:40 PDT 
Comment on attachment 155704 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 4 Kent Tamura 2012-07-31 20:25:47 PDT 
Comment on attachment 155704 [details]
Patch 1

ok
Comment 5 yosin 2012-07-31 20:29:43 PDT 
Comment on attachment 155704 [details]
Patch 1

Clearing flags on attachment: 155704

Committed r124290: <http://trac.webkit.org/changeset/124290>
Comment 6 yosin 2012-07-31 20:29:47 PDT 
All reviewed patches have been landed.  Closing bug.