Bug 94195 - [Forms] Enable multiple fields time input UI for Chromium except Android
Summary: [Forms] Enable multiple fields time input UI for Chromium except Android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords: WebExposed
Depends on: 94196 94297
Blocks: 88970
  Show dependency treegraph
 
Reported: 2012-08-16 00:31 PDT by yosin
Modified: 2012-08-17 02:49 PDT (History)
2 users (show)

See Also:


Attachments
Patch 1 (1.91 KB, patch)
2012-08-16 00:55 PDT, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-16 00:31:01 PDT
This is the final step of launching multiple fields time input UI.
Comment 1 yosin 2012-08-16 00:55:08 PDT
Created attachment 158738 [details]
Patch 1
Comment 2 yosin 2012-08-17 01:14:21 PDT
Comment on attachment 158738 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-08-17 01:19:47 PDT
Please fix Bug 94297 before enabling it.
Comment 4 Kent Tamura 2012-08-17 01:33:45 PDT
(In reply to comment #3)
> Please fix Bug 94297 before enabling it.

We discussed offline.  Bug 94297 is a test code issue, not a production code issue. So we may go ahead with this bug.
Comment 5 Kent Tamura 2012-08-17 01:34:05 PDT
Comment on attachment 158738 [details]
Patch 1

ok
Comment 6 yosin 2012-08-17 01:35:27 PDT
Comment on attachment 158738 [details]
Patch 1

Clearing flags on attachment: 158738

Committed r125868: <http://trac.webkit.org/changeset/125868>
Comment 7 yosin 2012-08-17 01:35:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Peter Beverloo 2012-08-17 02:28:14 PDT
What are the plans for enabling this on Android?
Comment 9 Kent Tamura 2012-08-17 02:30:01 PDT
(In reply to comment #8)
> What are the plans for enabling this on Android?

Android already has input[type=time] with a different UI.
Comment 10 Peter Beverloo 2012-08-17 02:49:44 PDT
(In reply to comment #9)
> (In reply to comment #8)
> > What are the plans for enabling this on Android?
> 
> Android already has input[type=time] with a different UI.

Right, sorry, I misunderstood the title. It seems desirable to me to have the display in the <input> box match between platforms, while, for more convenient editing, Android should continue to use a pop-up for getting actual user input.

I'm a bit concerned about Android's date input types becoming very different in terms of feature support, i.e. the step attribute, display in the input box itself (should we display seconds or not), in the future maybe <input type=time multiple />, etcetera. I'll ask around internally here.