Bug 94195 – [Forms] Enable multiple fields time input UI for Chromium except Android

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

This is the final step of launching multiple fields time input UI.

Created attachment 158738 [details]
Patch 1

Comment on attachment 158738 [details]
Patch 1

Could you review this patch?
Thanks in advance.

[Kent Tamura]

Please fix Bug 94297 before enabling it.

[Kent Tamura]

(In reply to comment #3)
> Please fix Bug 94297 before enabling it.

We discussed offline.  Bug 94297 is a test code issue, not a production code issue. So we may go ahead with this bug.

[Kent Tamura]

Comment on attachment 158738 [details]
Patch 1

ok

Comment on attachment 158738 [details]
Patch 1

Clearing flags on attachment: 158738

Committed r125868: <http://trac.webkit.org/changeset/125868>

All reviewed patches have been landed.  Closing bug.

[Peter Beverloo]

What are the plans for enabling this on Android?

[Kent Tamura]

(In reply to comment #8)
> What are the plans for enabling this on Android?

Android already has input[type=time] with a different UI.

[Peter Beverloo]

(In reply to comment #9)
> (In reply to comment #8)
> > What are the plans for enabling this on Android?
> 
> Android already has input[type=time] with a different UI.

Right, sorry, I misunderstood the title. It seems desirable to me to have the display in the <input> box match between platforms, while, for more convenient editing, Android should continue to use a pop-up for getting actual user input.

I'm a bit concerned about Android's date input types becoming very different in terms of feature support, i.e. the step attribute, display in the input box itself (should we display seconds or not), in the future maybe <input type=time multiple />, etcetera. I'll ask around internally here.