Bug 94297 - [Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Windows
Summary: [Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 94195
  Show dependency tree / graph
 
Reported: 2012-08-16 22:45 PDT by yosin
Modified: 2012-08-19 19:25 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (3.28 KB, patch)
2012-08-19 19:08 PDT, yosin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-16 22:45:26 PDT 
There are something wrong in date format detection code:


function checkHasShortFormat()
{
    var container = document.createElement("span");
    container.innerHTML = "<input type=time id=step60 step=60><input type=time id=step1 step=1>";
    document.body.appendChild(container);
    var hasShortFormat = document.getElementById("step60").offsetWidth != document.getElementById("step1").offsetWidth;
    container.parentElement.removeChild(container);
    return hasShortFormat;
}
Comment 1 yosin 2012-08-19 19:08:48 PDT 
Created attachment 159319 [details]
Patch 1
Comment 2 yosin 2012-08-19 19:09:29 PDT 
Comment on attachment 159319 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-08-19 19:11:58 PDT 
Comment on attachment 159319 [details]
Patch 1

ok
Comment 4 yosin 2012-08-19 19:25:15 PDT 
Comment on attachment 159319 [details]
Patch 1

Clearing flags on attachment: 159319

Committed r125986: <http://trac.webkit.org/changeset/125986>
Comment 5 yosin 2012-08-19 19:25:20 PDT 
All reviewed patches have been landed.  Closing bug.