Bug 92834 – [CSS] Add selectors for multiple fields time input UI.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

In the implementation of multiple fields time input UI uses CSS selectors for easy customization of looking of UI.

This bug is one of preparations of multiple fields time input UI, bug 88970.

Created attachment 155716 [details]
Patch 1

Comment on attachment 155716 [details]
Patch 1

Could you review this patch?
Thanks in advance.

[Kent Tamura]

Comment on attachment 155716 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=155716&action=review

> Source/WebCore/ChangeLog:21
> +        (input::-webkit-datetime-edit-minute-field[disabled]): Added.
> +        (input::-webkit-datetime-edit-second-field[disabled]): Added.

Would you explain when they are used please? They aren't same as input[type=time]:disabled? Why they contain only minute and second?

> Source/WebCore/css/html.css:479
> +}

Do we need font-family:monospace?

> Source/WebCore/css/html.css:487
> +    color: GrayText;
> +}
> +
> +input::-webkit-datetime-edit-second-field[disabled] {
> +    color: GrayText;
> +}

Need a special care for Windows. like input[]:disabled in themeWin.css.

> Source/WebCore/css/html.css:538
> +    height: 1.5em;

Need a comment here in addition to ChangeLog.  It is confusing.

Created attachment 155738 [details]
Screenshot of multiple fields time input UI

(In reply to comment #3)
> (From update of attachment 155716 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155716&action=review
> 
> > Source/WebCore/ChangeLog:21
> > +        (input::-webkit-datetime-edit-minute-field[disabled]): Added.
> > +        (input::-webkit-datetime-edit-second-field[disabled]): Added.
> 

These selectors used for 
 - minute[disabled]: step>=3600 but format contains minute field, e.g. h:m
 - second[disabled]: step>=60 but format contains second field, e.g. h:m:s

I attached a screenshot for sample of multiple fields time input UI.

Created attachment 155743 [details]
Patch 2

(In reply to comment #3)
> (From update of attachment 155716 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155716&action=review
> > Source/WebCore/css/html.css:487
> > +    color: GrayText;
> > +}
> > +
> > +input::-webkit-datetime-edit-second-field[disabled] {
> > +    color: GrayText;
> > +}
> 

The intention of them is indicating users don't need to enter digits and can't be changed rather than disabling the field.

I'll use "readonly" instead of "disable" to avoid confusion.

Created attachment 155756 [details]
Patch 3

Comment on attachment 155756 [details]
Patch 3

Could you review this patch?
Thanks in advance.

= Changes since the last patch =
* Add font-family: monospace
* Use "readonly" attribute instead of "disabled" attribute for readonly fields.
* Add a comment about "height" property of spin button.

[Kent Tamura]

Comment on attachment 155756 [details]
Patch 3

Looks ok

Comment on attachment 155756 [details]
Patch 3

Clearing flags on attachment: 155756

Committed r124314: <http://trac.webkit.org/changeset/124314>

All reviewed patches have been landed.  Closing bug.