Bug 90036 - [Platform] Implement localizedDecimalSeparator function
Summary: [Platform] Implement localizedDecimalSeparator function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 88970
  Show dependency treegraph
 
Reported: 2012-06-26 19:03 PDT by yosin
Modified: 2012-07-27 01:13 PDT (History)
3 users (show)

See Also:


Attachments
Patch 1 (6.81 KB, patch)
2012-06-26 22:58 PDT, yosin
no flags Details | Formatted Diff | Diff
Patch 2 (6.87 KB, patch)
2012-06-26 23:30 PDT, yosin
no flags Details | Formatted Diff | Diff
Patch 3 (6.87 KB, patch)
2012-06-26 23:52 PDT, yosin
no flags Details | Formatted Diff | Diff
Patch 4 (6.99 KB, patch)
2012-06-27 21:28 PDT, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-06-26 19:03:25 PDT
For displaying millisecond in Time input fields UI needs to know localized decimal separator, e.g. "." in English, "," in French. Because date time format obtained from some platforms don't have millisecond, e.g. ICU.
Comment 1 yosin 2012-06-26 22:58:31 PDT
Created attachment 149683 [details]
Patch 1
Comment 2 yosin 2012-06-26 22:59:10 PDT
Comment on attachment 149683 [details]
Patch 1

Could you review this patch?
Thanks in advance.

* Local build on CR-Linux
* Local build on Mac
Comment 3 WebKit Review Bot 2012-06-26 23:15:36 PDT
Comment on attachment 149683 [details]
Patch 1

Attachment 149683 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13097680
Comment 4 yosin 2012-06-26 23:30:02 PDT
Created attachment 149689 [details]
Patch 2
Comment 5 yosin 2012-06-26 23:31:08 PDT
Comment on attachment 149689 [details]
Patch 2

Could you review this patch?
Thanks in advance.

== Change since last request ==
* Add #if ENABLE(INPUT_TIME_FIELDS) to LocalizedNumberICU.cpp
Comment 6 WebKit Review Bot 2012-06-26 23:39:32 PDT
Comment on attachment 149689 [details]
Patch 2

Attachment 149689 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13087780
Comment 7 yosin 2012-06-26 23:52:25 PDT
Created attachment 149692 [details]
Patch 3
Comment 8 yosin 2012-06-26 23:53:12 PDT
Comment on attachment 149692 [details]
Patch 3

Could you review this patch?
Thanks in advance.

== Changes since last request ==
* Fix LocalizedNumberICUTest.cpp
Comment 9 Kent Tamura 2012-06-27 20:32:06 PDT
Comment on attachment 149692 [details]
Patch 3

ok except the ENABLE flag name.
Comment 10 yosin 2012-06-27 21:28:36 PDT
Created attachment 149863 [details]
Patch 4
Comment 11 yosin 2012-06-27 21:29:25 PDT
Comment on attachment 149692 [details]
Patch 3

Could you review this patch?
Thanks in advance.

== Change since last review ==
* Rename ENABLE flag to ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS
Comment 12 Kent Tamura 2012-06-27 21:55:08 PDT
Comment on attachment 149863 [details]
Patch 4

ok
Comment 13 yosin 2012-06-27 21:58:14 PDT
Comment on attachment 149863 [details]
Patch 4

Clearing flags on attachment: 149863

Committed r121404: <http://trac.webkit.org/changeset/121404>
Comment 14 yosin 2012-06-27 21:58:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Adam Barth 2012-07-27 01:13:46 PDT
Comment on attachment 149692 [details]
Patch 3

Cleared review? from obsolete attachment 149692 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).