Currently the unified spellchecker and un-unified spellchecker do not share the code to mark misspellings. They should be merged.
Created attachment 118019 [details] Patch
Created attachment 118196 [details] Patch
Comment on attachment 118196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118196&action=review Could you split the patch into some trivial part (like renaming, exporting an internal class, etc.) and possibly-observable change like make marking code shared? > Source/WebCore/ChangeLog:6 > + Need a short description and bug URL (OOPS!) You don't need this. > Source/WebCore/editing/SpellChecker.h:80 > + class InternalSpellCheckRequest; This doesn't need to be a nested class.
Created attachment 118534 [details] Patch
Comment on attachment 118534 [details] Patch Attachment 118534 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10780559
Comment on attachment 118534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118534&action=review > Source/WebCore/editing/SpellChecker.cpp:175 > + m_frame->editor()->markAndReplaceFor(m_processingRequest->mask(), results, m_processingRequest->checkingRange(), m_processingRequest->paragraphRange()); Could you pass SpellCheckRequest directly markAndReplaceFor() , instead of passing independent parameters.
Created attachment 118558 [details] Patch
Comment on attachment 118558 [details] Patch Looks OK. Thanks for doing this!
Once this landed, could you write a test for Bug 56368?
Comment on attachment 118558 [details] Patch Clearing flags on attachment: 118558 Committed r102553: <http://trac.webkit.org/changeset/102553>
All reviewed patches have been landed. Closing bug.
(In reply to comment #9) > Once this landed, could you write a test for Bug 56368? Yes.