Editor::markAllMisspellingsAndBadGrammarInRanges() should be refactored to unify the paths of Unified SpellChecker and Un-unified SpellChecker for adding markers.
(In reply to comment #0) > Editor::markAllMisspellingsAndBadGrammarInRanges() should be refactored > to unify the paths of Unified SpellChecker and Un-unified SpellChecker for adding markers. Also, SpellChecker::requestCheckingFor should be refactored.
Created attachment 117855 [details] Patch
Comment on attachment 117855 [details] Patch Attachment 117855 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10734618 New failing tests: svg/custom/linking-uri-01-b.svg
Comment on attachment 117855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117855&action=review Basically looks nice. There are only a few nits. > Source/WebCore/editing/Editor.cpp:2045 > + ExceptionCode ec = 0; It's good opportunity to eliminate this. You can use ASSERT_NO_EXCEPTION. > Source/WebCore/editing/Editor.h:39 > +#include "TextCheckingHelper.h" I really want hide this in .cpp file. > Source/WebCore/editing/Editor.h:408 > + void markAndReplaceFor(TextCheckingTypeMask, const Vector<TextCheckingResult>&, TextCheckingParagraph spellingParagraph, TextCheckingParagraph grammarParagraph); Is it possible to pass TextCheckingParagraph as a reference or a pointer?
Created attachment 117950 [details] Patch
Comment on attachment 117950 [details] Patch Clearing flags on attachment: 117950 Committed r102111: <http://trac.webkit.org/changeset/102111>
All reviewed patches have been landed. Closing bug.
This patch broke compilation on several platforms. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac%20Builder%20%28CG%29/builds/3684 ../editing/SpellingCorrectionController.h:58:1: error: struct 'TextCheckingResult' was previously declared as a class [-Werror,-Wmismatched-tags] struct TextCheckingResult; ^ ../editing/Editor.h:66:7: note: previous use is here class TextCheckingResult; ^ 1 error generated. Rolled out: <http://trac.webkit.org/changeset/102120> Reopening.
Created attachment 118153 [details] Patch
Comment on attachment 118153 [details] Patch Clearing flags on attachment: 118153 Committed r102218: <http://trac.webkit.org/changeset/102218>