RESOLVED FIXED 74033
Refactoring: SpellChecker::requestCheckingFor should take SpellCheckRequest object 
https://bugs.webkit.org/show_bug.cgi?id=74033
Summary Refactoring: SpellChecker::requestCheckingFor should take SpellCheckRequest o...
Shinya Kawanaka
Reported 2011-12-07 16:15:40 PST
This will make it easy to merge asynchronous path and synchronous path of spellcheck.
Attachments
Patch (11.27 KB, patch)
2011-12-07 21:11 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (11.62 KB, patch)
2011-12-08 00:00 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2011-12-07 21:11:56 PST
Created attachment 118325 [details] Patch
Hajime Morrita
Comment 2 2011-12-07 23:02:38 PST
Comment on attachment 118325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118325&action=review Basically looks fine. let's have one iteration. > Source/WebCore/editing/SpellChecker.cpp:127 > + request->setSequence(++m_lastRequestSequence); Let us make sure that published id never conflict against the magic number. I know this will never happen in reality, but preventing it explicitly gives us more confidence. > Source/WebCore/editing/SpellChecker.h:66 > + Element* m_rootEditableElement; Let's make this RefPtr to prevent possible dangling pointer access. > Source/WebCore/editing/SpellChecker.h:78 > + static PassRefPtr<SpellCheckRequest> createRequest(TextCheckingTypeMask, PassRefPtr<Range> checkingRange, PassRefPtr<Range> paragraphRange); SpellCheckerRequest::create() is our standard way if there is no special reason.
Shinya Kawanaka
Comment 3 2011-12-08 00:00:46 PST
Created attachment 118340 [details] Patch
WebKit Review Bot
Comment 4 2011-12-08 02:46:47 PST
Comment on attachment 118340 [details] Patch Clearing flags on attachment: 118340 Committed r102328: <http://trac.webkit.org/changeset/102328>
WebKit Review Bot
Comment 5 2011-12-08 02:46:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.