Bug 73889 - TextCheckingParagraph::offsetTo should not have side effect.
Summary: TextCheckingParagraph::offsetTo should not have side effect.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 73616
  Show dependency tree / graph
 
Reported: 2011-12-05 22:18 PST by Shinya Kawanaka
Modified: 2011-12-06 03:24 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2011-12-05 23:03 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2011-12-05 23:27 PST, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2011-12-05 22:18:35 PST 
TextCheckingParagraph::offsetTo changes m_offsetAsRange.

That often caused unexpected bugs, especially when changing Editor and  SpellChecker.
This side effect should be eliminated.
Comment 1 Shinya Kawanaka 2011-12-05 23:03:40 PST 
Created attachment 117994 [details]
Patch
Comment 2 Hajime Morrita 2011-12-05 23:09:04 PST 
Comment on attachment 117994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=117994&action=review

> Source/WebCore/editing/TextCheckingHelper.cpp:161
> +    if (ec)

I guess this never fail. you can use ASSERT_NO_EXCEPTION.
Comment 3 Shinya Kawanaka 2011-12-05 23:27:25 PST 
Created attachment 117996 [details]
Patch
Comment 4 WebKit Review Bot 2011-12-06 03:24:19 PST 
Comment on attachment 117996 [details]
Patch

Clearing flags on attachment: 117996

Committed r102118: <http://trac.webkit.org/changeset/102118>
Comment 5 WebKit Review Bot 2011-12-06 03:24:23 PST 
All reviewed patches have been landed.  Closing bug.