Bug 74035 - Editor::markAndReplaceFor should take Range instead of TextCheckingParagraph.
Summary: Editor::markAndReplaceFor should take Range instead of TextCheckingParagraph.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 73616
  Show dependency treegraph
 
Reported: 2011-12-07 16:21 PST by Shinya Kawanaka
Modified: 2011-12-07 20:26 PST (History)
1 user (show)

See Also:


Attachments
Patch (13.31 KB, patch)
2011-12-07 16:56 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff
Patch (13.48 KB, patch)
2011-12-07 18:07 PST, Shinya Kawanaka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2011-12-07 16:21:08 PST
To merge asynchronous path and synchronous path of spellchecking, markAndReplaceFor should take Range instead of TextCheckingParagraph.
Comment 1 Shinya Kawanaka 2011-12-07 16:56:01 PST
Created attachment 118288 [details]
Patch
Comment 2 Hajime Morrita 2011-12-07 17:48:43 PST
Comment on attachment 118288 [details]
Patch

Looks nice.
You can now remove the forward declaration of TextCheckingParagraph in Editor.h
Comment 3 Shinya Kawanaka 2011-12-07 18:07:56 PST
Created attachment 118300 [details]
Patch
Comment 4 WebKit Review Bot 2011-12-07 20:26:02 PST
Comment on attachment 118300 [details]
Patch

Clearing flags on attachment: 118300

Committed r102307: <http://trac.webkit.org/changeset/102307>
Comment 5 WebKit Review Bot 2011-12-07 20:26:06 PST
All reviewed patches have been landed.  Closing bug.