Bug 48728 - test-webkitpy fails when run with Win32 Python
Summary: test-webkitpy fails when run with Win32 Python
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords: PlatformOnly
Depends on: 49472 49475 49476 53822 54525 54526 54527 48072 48883 49033 49474 54520 54699 54700 54703 54709 54788 54790 64950 64959
Blocks: 48166 48517
  Show dependency treegraph
 
Reported: 2010-10-31 09:44 PDT by Adam Roben (:aroben)
Modified: 2011-07-25 21:25 PDT (History)
8 users (show)

See Also:


Attachments
Rollup patch of all of the changes necessary to get test-webkitpy to run cleanly on win32 (21.84 KB, patch)
2011-02-15 19:59 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch to blacklist failing test suites - obsolete, moving to a different bug. (2.20 KB, patch)
2011-02-17 19:11 PST, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-10-31 09:44:46 PDT
Lots of tests fail when you run test-webkitpy with Win32 Python. I believe this is currently expected, but we should fix it! I'll use this as an umbrella bug and block it on individual fixes.
Comment 1 Dimitri Glazkov (Google) 2010-10-31 09:58:46 PDT
+1
Comment 2 Dirk Pranke 2011-02-15 19:59:36 PST
Created attachment 82578 [details]
Rollup patch of all of the changes necessary to get test-webkitpy to run cleanly on win32
Comment 3 Dirk Pranke 2011-02-15 20:00:57 PST
I've attached a roll-up patch ... if you apply it, test-webkitpy should run cleanly. I will break the patch up into smaller chunks for review and file a few sub-bugs to track particular issues that we might want to consider.
Comment 4 Dirk Pranke 2011-02-17 19:11:14 PST
Created attachment 82899 [details]
Patch to blacklist failing test suites - obsolete, moving to a different bug.
Comment 5 Adam Roben (:aroben) 2011-02-17 19:24:24 PST
Comment on attachment 82899 [details]
Patch to blacklist failing test suites - obsolete, moving to a different bug.

Dirk, would you mind filing a new bug for this patch? It would be nice to keep this one as an umbrella for fixing the real issues, not just skipping the tests. (Skipping them for now does seem like the right strategy, though.)
Comment 6 Dirk Pranke 2011-02-17 19:35:40 PST
Sure. I was thinking of leaving this bug open and just landing this patch, but a separate bug is fine, too.
Comment 7 Dirk Pranke 2011-02-23 19:41:59 PST
I've fixed all of the bugs I plan to fix as of now, so I'm disclaiming ownership of this :)