Bug 49476 – webkitpy.tool.bot.feeders_unittest.FeedersTest.test_commit_queue_feeder fails under Win32 Python

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Adam Roben (:aroben)]

To reproduce:

1. python WebKitTools\Scripts\test-webkitpy webkitpy.tool.bot.feeders_unittest.FeedersTest.test_commit_queue_feeder

It fails with the following output:

FAIL: test_commit_queue_feeder (webkitpy.tool.bot.feeders_unittest.FeedersTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\cygwin\home\Adam Roben\dev\WebKit\OpenSource\WebKitTools\Scripts\webkitpy\tool\bot\feeders_unittest.py", line 51, in test_commit_queue_feeder
    OutputCapture().assert_outputs(self, feeder.feed, expected_stderr=expected_stderr)
  File "C:\cygwin\home\Adam Roben\dev\WebKit\OpenSource\WebKitTools\Scripts\webkitpy\common\system\outputcapture.py", line 65, in assert_outputs
    testcase.assertEqual(stderr_string, expected_stderr)
AssertionError: "Warning, attachment 128 on bug 42 has invalid committer ([e-mail])\nWarning, attachment 128 on bug 42 has invalid committer ([e-mail])\nMOCK setting
flag 'commit-queue' to '-' on attachment '128' with comment 'Rejecting patch 128 from commit-queue.' and additional comment '[e-mail] does not have committer permissions according to
http://trac.webkit.org/browser/trunk/WebKitTools\\Scripts\\webkitpy\\common\\config\\committers.py.\n\n- If you do not have committer rights please read http://webkit.org/coding/contributing.html for
instructions on how to use bugzilla flags.\n\n- If you have committer rights please correct the error in WebKitTools\\Scripts\\webkitpy\\common\\config\\committers.py by adding yourself to the file (n
o review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.'\nMOCK: update_work_items: commit-queue [106, 197]\nFee
ding commit-queue items [106, 197]\n" != u"Warning, attachment 128 on bug 42 has invalid committer ([e-mail])\nWarning, attachment 128 on bug 42 has invalid committer (non-committer@e
xample.com)\nMOCK setting flag 'commit-queue' to '-' on attachment '128' with comment 'Rejecting patch 128 from commit-queue.' and additional comment '[e-mail] does not have committer
 permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.\n\n- If you do not have committer rights please read http://webkit.org/coding/c
ontributing.html for instructions on how to use bugzilla flags.\n\n- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yoursel
f to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.'\nMOCK: update_work_items: commit-queue
 [106, 197]\nFeeding commit-queue items [106, 197]\n"

[Adam Roben (:aroben)]

Note the backslashes in both the URL and path to committers.py.

This seems identical to bug 49475. Do we really need two separate tests for this?

[Fujii Hironori]

224414@main removed the test.