Bug 49475 – webkitpy.tool.commands.queues_unittest.FeederQueueTest.test_feeder_queue fails under Win32 Python

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Tools / Tests

[Adam Roben (:aroben)]

To reproduce:

1. python WebKitTools\Scripts\test-webkitpy webkitpy.tool.commands.queues_unittest.FeederQueueTest.test_feeder_queue

It fails with the following output:

FAIL: test_feeder_queue (webkitpy.tool.commands.queues_unittest.FeederQueueTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\cygwin\home\Adam Roben\dev\WebKit\OpenSource\WebKitTools\Scripts\webkitpy\tool\commands\queues_unittest.py", line 139, in test_feeder_queue
    self.assert_queue_outputs(queue, tool=tool, expected_stderr=expected_stderr)
  File "C:\cygwin\home\Adam Roben\dev\WebKit\OpenSource\WebKitTools\Scripts\webkitpy\tool\commands\queuestest.py", line 91, in assert_queue_outputs
    self.assert_outputs(queue.process_work_item, "process_work_item", [work_item], expected_stdout, expected_stderr, expected_exceptions)
  File "C:\cygwin\home\Adam Roben\dev\WebKit\OpenSource\WebKitTools\Scripts\webkitpy\tool\commands\queuestest.py", line 61, in assert_outputs
    expected_exception=exception)
  File "C:\cygwin\home\Adam Roben\dev\WebKit\OpenSource\WebKitTools\Scripts\webkitpy\common\system\outputcapture.py", line 65, in assert_outputs
    testcase.assertEqual(stderr_string, expected_stderr)
AssertionError: "Warning, attachment 128 on bug 42 has invalid committer ([e-mail])\nWarning, attachment 128 on bug 42 has invalid committer ([e-mail])\nMOCK setting
flag 'commit-queue' to '-' on attachment '128' with comment 'Rejecting patch 128 from commit-queue.' and additional comment '[e-mail] does not have committer permissions according to
http://trac.webkit.org/browser/trunk/WebKitTools\\Scripts\\webkitpy\\common\\config\\committers.py.\n\n- If you do not have committer rights please read http://webkit.org/coding/contributing.html for
instructions on how to use bugzilla flags.\n\n- If you have committer rights please correct the error in WebKitTools\\Scripts\\webkitpy\\common\\config\\committers.py by adding yourself to the file (n
o review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.'\nMOCK: update_work_items: commit-queue [106, 197]\nFee
ding commit-queue items [106, 197]\nFeeding EWS (1 r? patch, 1 new)\nMOCK: submit_to_ews: 103\n" != "Warning, attachment 128 on bug 42 has invalid committer ([e-mail])\nWarning, attac
hment 128 on bug 42 has invalid committer ([e-mail])\nMOCK setting flag 'commit-queue' to '-' on attachment '128' with comment 'Rejecting patch 128 from commit-queue.' and additional
comment '[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.\n\n- If you do not ha
ve committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.\n\n- If you have committer rights please correct the error in WebKitTools/Scri
pts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your
 committer rights.'\nMOCK: update_work_items: commit-queue [106, 197]\nFeeding commit-queue items [106, 197]\nFeeding EWS (1 r? patch, 1 new)\nMOCK: submit_to_ews: 103\n"

[Adam Roben (:aroben)]

Note the backslashes in both the URL (bad bad bad!) and in the path to committers.py (not so bad).

[Fujii Hironori]

this test was removed.