Bug 37042 - REGRESSION(r57020): Broke lots of builds. (Requested by dave_levin on #webkit).
Summary: REGRESSION(r57020): Broke lots of builds. (Requested by dave_levin on #webkit).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 36906
  Show dependency tree / graph
 
Reported: 2010-04-02 13:49 PDT by WebKit Review Bot
Modified: 2010-04-02 14:10 PDT (History)
4 users (show)

See Also:

Attachments
ROLLOUT of r57020 (13.99 KB, patch)
2010-04-02 13:49 PDT, WebKit Review Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2010-04-02 13:49:50 PDT 
http://trac.webkit.org/changeset/57020 broke the build:
Broke lots of builds. (Requested by dave_levin on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-04-02 13:49:59 PDT 
Created attachment 52448 [details]
ROLLOUT of r57020
Comment 2 Darin Adler 2010-04-02 14:03:26 PDT 
Comment on attachment 52448 [details]
ROLLOUT of r57020

I already fixed this. No need to do the "nuke from orbit" solution.
Comment 3 Darin Adler 2010-04-02 14:03:42 PDT 
http://trac.webkit.org/changeset/57022
Comment 4 Eric Seidel (no email) 2010-04-02 14:05:45 PDT 
Thanks Darin.

Looks like the commit-queue rollout code is broken anyway.  The commit-queue was just spinning endlessly:

1 patch in commit-queue [52448]
Landing patch
Adding ['webkit-bot-watchers@googlegroups.com'] to the CC list for bug 37042
Builders ["Windows Release (Build)", "Windows Debug (Build)", "Chromium Win Release", "Chromium Mac Release", "Chromium Linux Release"] are red. See http://build.webkit.org
Fetching: https://bugs.webkit.org/show_bug.cgi?id=35607&ctype=xml
Fetching: https://bugs.webkit.org/show_bug.cgi?id=36904&ctype=xml
Fetching: https://bugs.webkit.org/show_bug.cgi?id=37033&ctype=xml
Fetching: https://bugs.webkit.org/show_bug.cgi?id=35811&ctype=xml
Fetching: https://bugs.webkit.org/show_bug.cgi?id=37042&ctype=xml
Builders ["Windows Release (Build)", "Windows Debug (Build)", "Chromium Win Release", "Chromium Mac Release", "Chromium Linux Release"] are red. See http://build.webkit.org
Empty queue
No work item. Sleeping until 2010-04-02 14:08:30 (5 mins).

Adam and I will investigate.
Comment 5 Eric Seidel (no email) 2010-04-02 14:10:43 PDT 
We also probably shouldn't put the requestee in the Title of the bug?