Bug 36904 – Clean up chromium WebNotificationPresenter interface after notification changes

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Rafael Weinstein]

Now that https://bugs.webkit.org/show_bug.cgi?id=36625 and http://codereview.chromium.org/1383001 have landed. Go back and clean up old interface calls.

[Rafael Weinstein]

Created attachment 52216 [details]
Patch

[WebKit Review Bot]

Attachment 52216 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1625110

[Adam Barth]

Comment on attachment 52216 [details]
Patch

Ok, but please make sure you don't break the chromium build.  :)

[Rafael Weinstein]

Created attachment 52425 [details]
Patch

[WebKit Review Bot]

Attachment 52425 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1625177

[Rafael Weinstein]

Created attachment 52427 [details]
Patch

[WebKit Review Bot]

Attachment 52427 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1574167

[Rafael Weinstein]

Created attachment 52428 [details]
Patch

[David Levin]

Comment on attachment 52428 [details]
Patch


> diff --git a/WebKit/chromium/public/WebNotificationPresenter.h b/WebKit/chromium/public/WebNotificationPresenter.h

> +    virtual Permission checkPermission(const WebURL& url) = 0;
The parameter name "url" adds no information so it shouldn't be present.

> +    virtual void requestPermission(const WebSecurityOrigin& origin, WebNotificationPermissionCallback* callback) = 0;

"origin" and "callback" param names should be removed.

[Rafael Weinstein]

Created attachment 52430 [details]
Patch

[Adam Barth]

Comment on attachment 52430 [details]
Patch

Awesome!  Thanks.

[WebKit Commit Bot]

Comment on attachment 52430 [details]
Patch

Clearing flags on attachment: 52430

Committed r57026: <http://trac.webkit.org/changeset/57026>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.