[chromium] font fallback for generic fonts picks wrong font
Created attachment 52431 [details] Patch
I would like to write a test for this, but it relies on which fonts are available or not on your OS. The previous incarnation of this code landed without a test as well.
Comment on attachment 52431 [details] Patch So i'm confused by why adding "-webkit-" makes the logic right. I don't really know what the "-webkit-" magic font family names are for? Also, is this tested? If so, how? What tests need updates? Is it not possible to test due to needing a specific system config? r- for the lack of testing or explanation thereof.
OK. I now read the bug comment which explained lack of testing (ideally that would be in the ChangeLog). So I'm just missing the understanding of what the "-webkit-" part does...
Created attachment 52441 [details] Patch
Comment on attachment 52441 [details] Patch THanks.
Comment on attachment 52441 [details] Patch Clearing flags on attachment: 52441 Committed r57027: <http://trac.webkit.org/changeset/57027>
All reviewed patches have been landed. Closing bug.