Bug 37033 - [chromium] font fallback for generic fonts picks wrong font
Summary: [chromium] font fallback for generic fonts picks wrong font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-02 11:36 PDT by Evan Martin
Modified: 2010-04-02 15:23 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.71 KB, patch)
2010-04-02 11:45 PDT, Evan Martin
no flags Details | Formatted Diff | Diff
Patch (2.30 KB, patch)
2010-04-02 13:07 PDT, Evan Martin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2010-04-02 11:36:57 PDT
[chromium] font fallback for generic fonts picks wrong font
Comment 1 Evan Martin 2010-04-02 11:45:26 PDT
Created attachment 52431 [details]
Patch
Comment 2 Evan Martin 2010-04-02 11:46:23 PDT
I would like to write a test for this, but it relies on which fonts are available or not on your OS.  The previous incarnation of this code landed without a test as well.
Comment 3 Eric Seidel (no email) 2010-04-02 12:59:46 PDT
Comment on attachment 52431 [details]
Patch

So i'm confused by why adding "-webkit-" makes the logic right.  I don't really know what the "-webkit-" magic font family names are for?

Also, is this tested?  If so, how?  What tests need updates?  Is it not possible to test due to needing a specific system config?

r- for the lack of testing or explanation thereof.
Comment 4 Eric Seidel (no email) 2010-04-02 13:00:51 PDT
OK.  I now read the bug comment which explained lack of testing (ideally that would be in the ChangeLog).  So I'm just missing the understanding of what the "-webkit-" part does...
Comment 5 Evan Martin 2010-04-02 13:07:46 PDT
Created attachment 52441 [details]
Patch
Comment 6 Eric Seidel (no email) 2010-04-02 13:08:41 PDT
Comment on attachment 52441 [details]
Patch

THanks.
Comment 7 WebKit Commit Bot 2010-04-02 15:23:32 PDT
Comment on attachment 52441 [details]
Patch

Clearing flags on attachment: 52441

Committed r57027: <http://trac.webkit.org/changeset/57027>
Comment 8 WebKit Commit Bot 2010-04-02 15:23:37 PDT
All reviewed patches have been landed.  Closing bug.