Bug 35811 - [chromium] need DragImage implementation
Summary: [chromium] need DragImage implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 37069
  Show dependency treegraph
 
Reported: 2010-03-05 14:22 PST by Evan Stade
Modified: 2010-04-06 12:17 PDT (History)
10 users (show)

See Also:


Attachments
try1 (7.03 KB, patch)
2010-03-05 14:53 PST, Evan Stade
no flags Details | Formatted Diff | Diff
style (7.03 KB, patch)
2010-03-05 14:59 PST, Evan Stade
no flags Details | Formatted Diff | Diff
forgot to svn add (9.02 KB, patch)
2010-03-05 15:15 PST, Evan Stade
no flags Details | Formatted Diff | Diff
style, 2 (9.41 KB, patch)
2010-03-05 15:23 PST, Evan Stade
no flags Details | Formatted Diff | Diff
mac build fix (9.40 KB, patch)
2010-03-05 16:01 PST, Evan Stade
no flags Details | Formatted Diff | Diff
review comments (deleted)
2010-03-08 11:39 PST, Evan Stade
fishd: review-
Details | Formatted Diff | Diff
use WebImage, no mac implementation (16.14 KB, patch)
2010-03-08 19:24 PST, Evan Stade
fishd: review-
fishd: commit-queue-
Details | Formatted Diff | Diff
comment + style (5.56 KB, patch)
2010-03-16 19:28 PDT, Evan Stade
no flags Details | Formatted Diff | Diff
try to fix mysterious build failure (9.79 KB, patch)
2010-03-17 08:28 PDT, Evan Stade
no flags Details | Formatted Diff | Diff
fixed (17.24 KB, patch)
2010-03-17 08:41 PDT, Evan Stade
no flags Details | Formatted Diff | Diff
correct relative paths (15.51 KB, patch)
2010-03-17 08:43 PDT, Evan Stade
fishd: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
re-synced (10.39 KB, patch)
2010-04-01 14:43 PDT, Evan Stade
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
plus-- (10.38 KB, patch)
2010-04-02 11:07 PDT, Evan Stade
eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
space-- (10.38 KB, patch)
2010-04-02 13:23 PDT, Evan Stade
no flags Details | Formatted Diff | Diff
svn add (6.43 KB, patch)
2010-04-02 16:40 PDT, Evan Stade
no flags Details | Formatted Diff | Diff
null check (16.60 KB, patch)
2010-04-05 14:25 PDT, Evan Stade
no flags Details | Formatted Diff | Diff
scale image implemented (16.98 KB, patch)
2010-04-05 15:00 PDT, Evan Stade
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Stade 2010-03-05 14:22:21 PST
chromium currently has a stubbed DragImage implementation. We should add one based on Skia.
Comment 1 Evan Stade 2010-03-05 14:53:44 PST
Created attachment 50127 [details]
try1
Comment 2 WebKit Review Bot 2010-03-05 14:58:03 PST
Attachment 50127 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/chromium/DragImageRef.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Evan Stade 2010-03-05 14:59:53 PST
Created attachment 50129 [details]
style
Comment 4 WebKit Review Bot 2010-03-05 15:08:36 PST
Attachment 50127 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/335639
Comment 5 Evan Stade 2010-03-05 15:15:31 PST
Created attachment 50131 [details]
forgot to svn add
Comment 6 WebKit Review Bot 2010-03-05 15:20:57 PST
Attachment 50131 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/chromium/DragImageRef.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Evan Stade 2010-03-05 15:23:09 PST
Created attachment 50132 [details]
style, 2
Comment 8 WebKit Review Bot 2010-03-05 15:26:46 PST
Attachment 50132 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/chromium/DragImageRef.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Review Bot 2010-03-05 15:27:48 PST
Attachment 50129 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/336632
Comment 10 Evan Stade 2010-03-05 16:01:02 PST
Created attachment 50136 [details]
mac build fix
Comment 11 Evan Stade 2010-03-08 11:39:11 PST
Created attachment 50241 [details]
review comments
Comment 12 Darin Fisher (:fishd, Google) 2010-03-08 14:29:05 PST
Comment on attachment 50241 [details]
review comments

> Index: WebCore/platform/chromium/DragImageChromium.cpp
...
> +#if OS(DARWIN)
> +#include "skia/ext/skia_utils_mac.h"
> +#endif

Can you use CG in the Mac port instead?  We should really avoid using
skia/ext in WebCore.  It introduces a circular dependency between the
repositories!


> +DragImageRef createDragImageFromImage(Image* image)
> +{
> +#if OS(DARWIN)
> +    SkBitmap bitmap = gfx::CGImageToSkBitmap(image->getCGImageRef());

please avoid adding gfx:: namespace stuff to WebCore!  that stuff is
chromium only.


> Index: WebKit/chromium/ChangeLog
...
> +        * public/WebDragImageRef.h: Added.
> +        * src/DragClientImpl.cpp:
> +        (WebKit::DragClientImpl::startDrag):
> +        * src/WebViewImpl.cpp:
> +        (WebKit::WebViewImpl::startDragging):
> +        * src/WebViewImpl.h:

is there some other public interface change missing?  I don't see
any public API that uses WebDragImageRef.

also, please see WebImage.h to note how things differ between
WEBKIT_USING_SKIA and WEBKIT_USING_CG.

It seems like WebDragImageRef should be made consistent with
WebImage.
Comment 13 Evan Stade 2010-03-08 15:27:42 PST
(In reply to comment #12)
> (From update of attachment 50241 [details])
> > Index: WebCore/platform/chromium/DragImageChromium.cpp
> ...
> > +#if OS(DARWIN)
> > +#include "skia/ext/skia_utils_mac.h"
> > +#endif
> 
> Can you use CG in the Mac port instead?  We should really avoid using
> skia/ext in WebCore.  It introduces a circular dependency between the
> repositories!

we can use CG for Mac, but then we have to implement DragImageChromium twice, and fork a lot of code on the chrome side of this patch.

> 
> 
> > +DragImageRef createDragImageFromImage(Image* image)
> > +{
> > +#if OS(DARWIN)
> > +    SkBitmap bitmap = gfx::CGImageToSkBitmap(image->getCGImageRef());
> 
> please avoid adding gfx:: namespace stuff to WebCore!  that stuff is
> chromium only.

After talking to several mac people, this is the only way I could find to convert CG to SkBitmap. Is there a better way? If not I can leave the mac side unimplemented for the time being.

> 
> 
> > Index: WebKit/chromium/ChangeLog
> ...
> > +        * public/WebDragImageRef.h: Added.
> > +        * src/DragClientImpl.cpp:
> > +        (WebKit::DragClientImpl::startDrag):
> > +        * src/WebViewImpl.cpp:
> > +        (WebKit::WebViewImpl::startDragging):
> > +        * src/WebViewImpl.h:
> 
> is there some other public interface change missing?  I don't see
> any public API that uses WebDragImageRef.
> 
> also, please see WebImage.h to note how things differ between
> WEBKIT_USING_SKIA and WEBKIT_USING_CG.
> 
> It seems like WebDragImageRef should be made consistent with
> WebImage.

Yes, the change to WebViewClient::StartDragging is missing (see FIXME in WebViewImpl). That is not part of this patch because I am breaking it up into multiple pieces.
Comment 14 Evan Stade 2010-03-08 19:24:49 PST
Created attachment 50269 [details]
use WebImage, no mac implementation
Comment 15 WebKit Review Bot 2010-03-08 19:30:01 PST
Attachment 50269 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WARNING: Could not read file. Skipping: "WebCore/platform/chromium/DragImageChromium.cpp"
WebCore/platform/chromium/DragImageChromiumSkia.cpp:32:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
WebCore/platform/chromium/DragImageChromiumSkia.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 16 Darin Fisher (:fishd, Google) 2010-03-09 22:36:43 PST
Comment on attachment 50269 [details]
use WebImage, no mac implementation

> Index: WebKit/chromium/public/WebViewClient.h
...
>      virtual void startDragging(
> -        const WebPoint& from, const WebDragData&, WebDragOperationsMask) { }
> +        const WebDragData&, WebDragOperationsMask, const WebImage&, const WebPoint&) { }

Can you avoid making this a two-sided patch landing by continuing
to support the old API temporarily?


> Index: WebKit/chromium/src/DragClientImpl.cpp
...
> +#if WEBKIT_USING_SKIA
> +    m_webView->startDragging(
> +        dragData, static_cast<WebDragOperationsMask>(dragOperationMask),
> +        WebImage(*dragImage), offsetPoint);
> +#else
> +    // FIXME

^^^ Can you add a comment about this FIXME?  Something about needing
to pass a non-empty image perhaps?


Are the style bot issues something to worry about?
Comment 17 Evan Stade 2010-03-10 08:55:51 PST
(In reply to comment #16)
> (From update of attachment 50269 [details])
> > Index: WebKit/chromium/public/WebViewClient.h
> ...
> >      virtual void startDragging(
> > -        const WebPoint& from, const WebDragData&, WebDragOperationsMask) { }
> > +        const WebDragData&, WebDragOperationsMask, const WebImage&, const WebPoint&) { }
> 
> Can you avoid making this a two-sided patch landing by continuing
> to support the old API temporarily?

we can land the chrome side first now without anything breaking. Sorry, I should have mentioned that here. I only mentioned that at http://codereview.chromium.org/668125/show. So perhaps it would be best to review that side of it first?

> 
> 
> > Index: WebKit/chromium/src/DragClientImpl.cpp
> ...
> > +#if WEBKIT_USING_SKIA
> > +    m_webView->startDragging(
> > +        dragData, static_cast<WebDragOperationsMask>(dragOperationMask),
> > +        WebImage(*dragImage), offsetPoint);
> > +#else
> > +    // FIXME
> 
> ^^^ Can you add a comment about this FIXME?  Something about needing
> to pass a non-empty image perhaps?

ok

> 
> 
> Are the style bot issues something to worry about?

yes
Comment 18 Evan Stade 2010-03-16 19:28:03 PDT
Created attachment 50868 [details]
comment + style

the chrome side was landed. I have updated the patch. Possible to take another look? thanks.
Comment 19 WebKit Review Bot 2010-03-16 19:35:24 PDT
Attachment 50868 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/892042
Comment 20 Evan Stade 2010-03-17 08:28:43 PDT
Created attachment 50908 [details]
try to fix mysterious build failure

don't really understand the build failure. The chromium trybots like the patch ok.
Comment 21 WebKit Review Bot 2010-03-17 08:33:01 PDT
Attachment 50908 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WARNING: Could not read file. Skipping: "WebCore/platform/chromium/DragImageChromium.cpp"
WebCore/platform/chromium/DragImageChromiumSkia.cpp:32:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
WebCore/platform/chromium/DragImageChromiumSkia.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Evan Stade 2010-03-17 08:41:21 PDT
Created attachment 50910 [details]
fixed
Comment 23 Evan Stade 2010-03-17 08:43:05 PDT
Created attachment 50912 [details]
correct relative paths
Comment 24 Darin Fisher (:fishd, Google) 2010-03-30 17:11:56 PDT
Comment on attachment 50912 [details]
correct relative paths

r=me
Comment 25 WebKit Commit Bot 2010-04-01 13:09:11 PDT
Comment on attachment 50912 [details]
correct relative paths

Rejecting patch 50912 from commit-queue.

Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Fisher', '--force']" exit_code: 1
Last 500 characters of output:
ching file WebKit/chromium/src/DragClientImpl.cpp
patching file WebKit/chromium/src/WebViewImpl.cpp
Hunk #2 succeeded at 1933 (offset 49 lines).
patching file WebKit/chromium/public/WebViewClient.h
Hunk #1 FAILED at 47.
Hunk #2 succeeded at 223 (offset 3 lines).
1 out of 2 hunks FAILED -- saving rejects to file WebKit/chromium/public/WebViewClient.h.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/chromium/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Full output: http://webkit-commit-queue.appspot.com/results/1628184
Comment 26 Evan Stade 2010-04-01 14:43:34 PDT
Created attachment 52339 [details]
re-synced

synced to ToT
Comment 27 WebKit Commit Bot 2010-04-01 23:54:54 PDT
Comment on attachment 52339 [details]
re-synced

Rejecting patch 52339 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against webkit-patch.
Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--build-style=both', '--quiet', '52339', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
webkitpy/tool/commands/stepsequence.py", line 60, in _run
    step(tool, options).run(state)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 59, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 41, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'
Comment 28 Eric Seidel (no email) 2010-04-02 00:00:39 PDT
That was not a very elegant error on our part.

webkitpy.common.system.executive.ScriptError: Failed to parse ChangeLog: /Projects/WebKit/WebKit/chromium/ChangeLog

Seems to be the problem.
Comment 29 Eric Seidel (no email) 2010-04-02 00:01:18 PDT
Comment on attachment 52339 [details]
re-synced

Looks like your chromium changelog has a leading + sign.  That would throw our ChangeLog parser off. :)
Comment 30 Evan Stade 2010-04-02 11:07:08 PDT
Created attachment 52426 [details]
plus--
Comment 31 WebKit Commit Bot 2010-04-02 12:31:52 PDT
Comment on attachment 52426 [details]
plus--

Rejecting patch 52426 from commit-queue.

Unexpected failure when landing patch!  Please file a bug against webkit-patch.
Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '52426', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
webkitpy/tool/commands/stepsequence.py", line 60, in _run
    step(tool, options).run(state)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 59, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 41, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'
Comment 32 Eric Seidel (no email) 2010-04-02 12:44:01 PDT
This looks like another ChangeLog parsing problem.  Again, my apologies for our poor error reporting.

You can test this locally by running:
webkit-patch commit-message
Comment 33 Evan Stade 2010-04-02 13:23:00 PDT
Created attachment 52445 [details]
space--

thanks for the tip

Parsing ChangeLog: /usr/local/google/WebKit/WebKit/chromium/ChangeLog
Parsing ChangeLog: /usr/local/google/WebKit/WebCore/ChangeLog
2010-04-01  Evan Stade  <estade@chromium.org>

        Reviewed by NOBODY (OOPS!).

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Use the DragImageRef that the DragController passes to us.

        * public/WebViewClient.h:
        (WebKit::WebViewClient::startDragging):
        * src/DragClientImpl.cpp:
        (WebKit::DragClientImpl::startDrag):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::startDragging):
        * src/WebViewImpl.h:
2010-04-01  Evan Stade  <estade@chromium.org>

        Reviewed by NOBODY (OOPS!).

        [chromium] need DragImage implementation
        https://bugs.webkit.org/show_bug.cgi?id=35811

        Basic implementation using SkBitmap. Transformations are not supported
        yet. No implementation for mac.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/chromium/DragImageChromium.cpp:
        * platform/chromium/DragImageRef.h:
Comment 34 Eric Seidel (no email) 2010-04-02 13:29:51 PDT
Comment on attachment 52445 [details]
space--

Sorry our tools have been such trouble.  /me crosses fingers.
Comment 35 WebKit Commit Bot 2010-04-02 15:48:14 PDT
Comment on attachment 52445 [details]
space--

Clearing flags on attachment: 52445

Committed r57028: <http://trac.webkit.org/changeset/57028>
Comment 36 WebKit Commit Bot 2010-04-02 15:48:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 37 WebKit Review Bot 2010-04-02 16:00:27 PDT
http://trac.webkit.org/changeset/57028 might have broken Chromium Linux Release
Comment 38 Evan Stade 2010-04-02 16:40:55 PDT
Created attachment 52465 [details]
svn add

these two files got lost in the shuffle
Comment 39 Adam Barth 2010-04-02 16:45:35 PDT
Comment on attachment 52465 [details]
svn add

Clearing flags on attachment: 52465

Committed r57032: <http://trac.webkit.org/changeset/57032>
Comment 40 Adam Barth 2010-04-02 16:45:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 41 Darin Fisher (:fishd, Google) 2010-04-03 00:53:29 PDT
Just about drag-n-drop related layout test is now failing for the chromium build.  I think this needs to be reverted.
Comment 42 Nico Weber 2010-04-03 21:43:11 PDT
Mac side at https://bugs.webkit.org/show_bug.cgi?id=37069 .
Comment 43 Pavel Feldman 2010-04-04 07:09:04 PDT
(In reply to comment #41)
> Just about drag-n-drop related layout test is now failing for the chromium
> build.  I think this needs to be reverted.

I am on duty starting on Monday. Will revert this unless tests get fixed by Monday morning GMT.
Comment 44 Nico Weber 2010-04-04 09:22:18 PDT
I can look after the tests if someone tells me where the list of now failing tests is.
Comment 46 Nico Weber 2010-04-04 10:29:26 PDT
http://codereview.chromium.org/1591013 should do the trick.

I'm having troubles running layout tests locally (see my mail to chromium-dev), so I'm not 100% sure that it does, but it seems very likely that that's the cause.
Comment 47 Pavel Feldman 2010-04-04 23:31:34 PDT
Rolled out both r57028 and r57032.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	R	WebCore/platform/chromium/DragImageChromiumMac.cpp => WebCore/platform/chromium/DragImageChromium.cpp
	D	WebCore/platform/chromium/DragImageChromiumSkia.cpp
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gyp/WebCore.gyp
	M	WebCore/WebCore.gypi
	M	WebCore/platform/chromium/DragImageRef.h
	M	WebKit/chromium/ChangeLog
	M	WebKit/chromium/public/WebViewClient.h
	M	WebKit/chromium/src/DragClientImpl.cpp
	M	WebKit/chromium/src/WebViewImpl.cpp
	M	WebKit/chromium/src/WebViewImpl.h
Committed r57064
Comment 48 Evan Stade 2010-04-05 14:25:46 PDT
Created attachment 52573 [details]
null check

Fix was null check in DragClientImpl::startDragging
Comment 49 Nico Weber 2010-04-05 14:29:39 PDT
As said on the corresponding chrome bug, not implementing scaleDragImage() destroys the IPC connection when dragging big images, which looks like a renderer crash to the browser. If it's just a couple lines, maybe you can just implement it.
Comment 50 WebKit Review Bot 2010-04-05 14:32:49 PDT
Attachment 52573 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
ERROR: File does not exist: WebCore/platform/chromium/DragImageChromium.cpp


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 51 Eric Seidel (no email) 2010-04-05 14:34:29 PDT
Chris, this is an bug in check-webkit-style, no?
Comment 52 Nico Weber 2010-04-05 14:44:03 PDT
I retract my comment. I didn't realize that Evan does `return 0;` instead of `return image` in scaleDragImage().
Comment 53 Evan Stade 2010-04-05 15:00:39 PDT
Created attachment 52578 [details]
scale image implemented

Well, I couldn't get it to crash even for large images, but here is a scale implementation anyway (which appears to work, as scale is called on small images).
Comment 54 WebKit Review Bot 2010-04-05 15:04:41 PDT
Attachment 52578 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
ERROR: File does not exist: WebCore/platform/chromium/DragImageChromium.cpp


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 55 Chris Jerdonek 2010-04-05 15:48:03 PDT
(In reply to comment #51)
> Chris, this is an bug in check-webkit-style, no?

I think so.  I had originally made it just log a message, but Shinichiro requested that I change it to raise an exception:

https://bugs.webkit.org/show_bug.cgi?id=36957#c3
Comment 56 Chris Jerdonek 2010-04-05 16:00:46 PDT
(In reply to comment #55)
> (In reply to comment #51)
> > Chris, this is an bug in check-webkit-style, no?
> 
> I think so.  I had originally made it just log a message, but Shinichiro
> requested that I change it to raise an exception:
> 
> https://bugs.webkit.org/show_bug.cgi?id=36957#c3

Filed bug here:

https://bugs.webkit.org/show_bug.cgi?id=37122
Comment 57 Dimitri Glazkov (Google) 2010-04-06 08:51:38 PDT
Comment on attachment 52578 [details]
scale image implemented

ok.
Comment 58 WebKit Commit Bot 2010-04-06 12:17:16 PDT
Comment on attachment 52578 [details]
scale image implemented

Clearing flags on attachment: 52578

Committed r57162: <http://trac.webkit.org/changeset/57162>
Comment 59 WebKit Commit Bot 2010-04-06 12:17:27 PDT
All reviewed patches have been landed.  Closing bug.