The texImage2D and texSubImage2D entry points which upload DOM resources (Image, ImageData, ImageBitmap) to WebGL textures contain duplicated code. In order to upgrade these to WebGL 2.0 functionality and also support uploads to 3D textures, they must be refactored into common helpers.
Have started this.
Created attachment 397532 [details]
Work in progress
Checkpointing the current patch above - not for review or testing yet.
Created attachment 398117 [details]
Created attachment 398124 [details]
Created attachment 398158 [details]
Created attachment 398202 [details]
Created attachment 398211 [details]
Created attachment 398220 [details]
Requesting review at this point. The majority of this patch is the large rebaselines, which per the ChangeLog, get dozens of WebGL 2.0 conformance tests passing completely.
The layout test flakes seen in some of the dry runs are unrelated to these code changes.
Comment on attachment 398220 [details]
Our review tool can't handle this large a patch. Hopefully the cq does.
I had a couple of minor comments that can be fixed in a follow-up. e.g. using enum class for TexFuncValidationSourceType and others.
Thanks Ken, this is fantastic.
Committed r261023: <https://trac.webkit.org/changeset/261023>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 398220 [details].