Bug 209513 - [WebGL2] Context state updates
Summary: [WebGL2] Context state updates
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
Keywords: InRadar
Depends on: 205823 208875 209516 209518 210766 213906
Blocks: 126404
  Show dependency treegraph
Reported: 2020-03-24 15:29 PDT by Kenneth Russell
Modified: 2020-07-25 12:49 PDT (History)
10 users (show)

See Also:

Patch (15.07 KB, patch)
2020-07-24 19:16 PDT, Kenneth Russell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-03-24 15:29:06 PDT
Updates are needed for WebGL 2.0 in the following methods which get and set global context state:
Comment 1 Kenneth Russell 2020-07-24 12:29:06 PDT
Taking this. Most if not all of these were already upgraded in other bugs.
Comment 2 Kenneth Russell 2020-07-24 14:42:25 PDT
With recent updates from Bug 208875, Bug 209518, Bug 213906, and others, getParameter appears to be complete.
Comment 3 Kenneth Russell 2020-07-24 14:55:25 PDT
With recent updates from Bug 205823, Bug 209518, Bug 213906, and perhaps others, getIndexedParameter appears to be fully implemented.
Comment 4 Kenneth Russell 2020-07-24 16:55:35 PDT
Looking into isEnabled and in particular validateCapability, it was found that a couple of methods were placed on WebGLRenderingContext earlier so that they could be overridden in WebGL2RenderingContext. Mmoving them to WebGLRenderingContextBase removes duplicated code, so will put up a patch for that.

pixelStorei was completed in Bug 209516 and Bug 210766.
Comment 5 Kenneth Russell 2020-07-24 19:16:59 PDT
Created attachment 405216 [details]
Comment 6 EWS 2020-07-25 12:49:01 PDT
Committed r264889: <https://trac.webkit.org/changeset/264889>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405216 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-25 12:49:26 PDT