Bug 209515 – [WebGL2] Update texture packing code for software uploads from DOM

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Kenneth Russell]

The texture packing code for software texture uploads from DOM elements needs to be updated to support WebGL 2.0 formats. This includes code in:

Source/WebCore/platform/graphics/FormatConverter.{cpp,h}
Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp, GraphicsContextGLOpenGL::packPixels

and others.

[Kenneth Russell]

Created attachment 397290 [details]
Patch

[Dean Jackson]

Comment on attachment 397290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397290&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4338
> +    uint8_t* data = reinterpret_cast<uint8_t*>(
> +        pixels ? pixels->baseAddress() : nullptr); // NEEDS_PORT

We tend to do this on one line.

[Kenneth Russell]

Comment on attachment 397290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397290&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4338
>> +        pixels ? pixels->baseAddress() : nullptr); // NEEDS_PORT
> 
> We tend to do this on one line.

OK, will keep that in mind and fix this up in a subsequent patch. I'd like to try to get this in sooner so am CQ+'ing it now.

[EWS]

Committed r260588: <https://trac.webkit.org/changeset/260588>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397290 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62257803>