Bug 211338 – REGRESSION(r261023): [GTK][WPE] Several WebGL tests are failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Diego Pino]

Many tests are failing bot in GTK and WPE after r261023:

See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r261031%20(13598)/results.html

WebKit Results Database: https://results.webkit.org/?platform=GTK&platform=ios&platform=WPE&suite=layout-tests&test=fast%2Fcanvas%2Fwebgl%2Ftex-image-and-sub-image-2d-with-array-buffer-view.html

webgl/1.0.3/conformance/more/functions/copyTexImage2DBadArgs.html [ Crash ]
fast/canvas/webgl/invalid-passed-params.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-potentially-subsampled-image.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html [ Failure ]
fast/canvas/webgl/tex-image-with-format-and-type.html [ Failure ]
fast/canvas/webgl/tex-input-validation.html [ Failure ]
fast/canvas/webgl/tex-sub-image-2d-bad-args.html [ Failure ]
fast/canvas/webgl/tex-sub-image-2d.html [ Failure ]
fast/canvas/webgl/tex-sub-image-cube-maps.html [ Failure ]
fast/canvas/webgl/uninitialized-test.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-float-with-canvas.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-float-with-image-data.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-float-with-image.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-half-float-with-canvas.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-half-float-with-image-data.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-half-float-with-image.html [ Failure ]
webgl/1.0.3/conformance/misc/invalid-passed-params.html [ Failure ]
webgl/1.0.3/conformance/misc/uninitialized-test.html [ Failure ]
webgl/1.0.3/conformance/more/functions/texSubImage2D.html [ Failure ]
webgl/1.0.3/conformance/more/functions/texSubImage2DBadArgs.html [ Failure ]
webgl/1.0.3/conformance/more/functions/texSubImage2DHTMLBadArgs.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-svg-image.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgb565.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba4444.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-with-format-and-type.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-input-validation.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-sub-image-2d-bad-args.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-sub-image-2d.html [ Failure ]
webgl/1.0.3/conformance/textures/texture-sub-image-cube-maps.html [ Failure ]
webgl/1.0.3/conformance/textures/texture-upload-cube-maps.html [ Failure ]
http/tests/webgl/1.0.2/texSubImage2DHTML.html [ Failure ]

WPE:

webgl/1.0.3/conformance/more/functions/copyTexImage2DBadArgs.html [ Crash ]
fast/canvas/webgl/invalid-passed-params.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba4444.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-potentially-subsampled-image.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html [ Failure ]
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html [ Failure ]
fast/canvas/webgl/tex-image-with-format-and-type.html [ Failure ]
fast/canvas/webgl/tex-input-validation.html [ Failure ]
fast/canvas/webgl/tex-sub-image-2d-bad-args.html [ Failure ]
fast/canvas/webgl/tex-sub-image-2d.html [ Failure ]
fast/canvas/webgl/tex-sub-image-cube-maps.html [ Failure ]
fast/canvas/webgl/uninitialized-test.html [ Failure ]
http/tests/webgl/1.0.2/texSubImage2DHTML.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-float-with-canvas.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-float-with-image-data.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-float-with-image.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-half-float-with-canvas.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-half-float-with-image-data.html [ Failure ]
webgl/1.0.3/conformance/extensions/oes-texture-half-float-with-image.html [ Failure ]
webgl/1.0.3/conformance/misc/invalid-passed-params.html [ Failure ]
webgl/1.0.3/conformance/misc/uninitialized-test.html [ Failure ]
webgl/1.0.3/conformance/more/functions/texSubImage2D.html [ Failure ]
webgl/1.0.3/conformance/more/functions/texSubImage2DBadArgs.html [ Failure ]
webgl/1.0.3/conformance/more/functions/texSubImage2DHTMLBadArgs.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-image.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-svg-image.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgb565.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba4444.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-image-with-format-and-type.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-input-validation.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-sub-image-2d-bad-args.html [ Failure ]
webgl/1.0.3/conformance/textures/tex-sub-image-2d.html [ Failure ]
webgl/1.0.3/conformance/textures/texture-size.html [ Failure ]
webgl/1.0.3/conformance/textures/texture-sub-image-cube-maps.html [ Failure ]
webgl/1.0.3/conformance/textures/texture-upload-cube-maps.html [ Failure ]

[Zan Dobersek]

Created attachment 398357 [details]
WIP

[Zan Dobersek]

(In reply to Zan Dobersek from comment #1)
> Created attachment 398357 [details]
> WIP

Basically, on non-ANGLE code paths we have to retrieve the internal format value from the texture object, as done before the refactor.

[Kenneth Russell]

Comment on attachment 398357 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=398357&action=review

Thanks very much for catching and fixing this error. I'm no longer a reviewer but perhaps dino can review this? One slight issue with the ChangeLog.

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

This line will need to be removed from the ChangeLog in order for the CQ to accept the patch. (This is actually mentioned by the style bot.)

[Kenneth Russell]

Zan: do you need any help revising this patch for landing?

[Zan Dobersek]

(In reply to Kenneth Russell from comment #4)
> Zan: do you need any help revising this patch for landing?

No, sorry -- it just fell into my backlog.

[Zan Dobersek]

Created attachment 399250 [details]
Patch for landing

[Zan Dobersek]

Comment on attachment 399250 [details]
Patch for landing

Clearing flags on attachment: 399250

Committed r261609: <https://trac.webkit.org/changeset/261609>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/63178620>