Bug 206225 – REGRESSION (r254483): media/track/track-cues-sorted-before-dispatch.html became very flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[WebKit Commit Bot]

This is an automatically generated bug from the commit-queue.
media/track/track-cues-sorted-before-dispatch.html has been flaky on the commit-queue.

media/track/track-cues-sorted-before-dispatch.html was authored by [e-mail] and [e-mail].
https://trac.webkit.org/browser/trunk/LayoutTests/media/track/track-cues-sorted-before-dispatch.html

The commit-queue just saw media/track/track-cues-sorted-before-dispatch.html flake (text diff) while processing attachment 387642 [details] on bug 206127.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

The bots will update this with information from each new failure.

If you believe this bug to be fixed or invalid, feel free to close.  The bots will re-open if the flake re-occurs.

If you would like to track this test fix with another bug, please close this bug as a duplicate.  The bots will follow the duplicate chain when making future comments.

[WebKit Commit Bot]

Created attachment 387644 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw media/track/track-cues-sorted-before-dispatch.html flake (text diff) while processing attachment 387699 [details] on bug 206255.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 387720 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw media/track/track-cues-sorted-before-dispatch.html flake (text diff) while processing attachment 387767 [details] on bug 206175.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 387770 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw media/track/track-cues-sorted-before-dispatch.html flake (text diff) while processing attachment 387791 [details] on bug 206288.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 387814 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw media/track/track-cues-sorted-before-dispatch.html flake (text diff) while processing attachment 387655 [details] on bug 206233.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 387820 [details]
Archive of layout-test-results from webkit-cq-01

[Alexey Proskuryakov]

This test has always been somewhat flaky, but it became extremely flaky with http://trac.webkit.org/r254483

https://results.webkit.org/?limit=50000&suite=layout-tests&test=media%2Ftrack%2Ftrack-cues-sorted-before-dispatch.html

[Alexey Proskuryakov]

This test has always been somewhat flaky, but it became extremely flaky with http://trac.webkit.org/r254483

https://results.webkit.org/?limit=50000&suite=layout-tests&test=media%2Ftrack%2Ftrack-cues-sorted-before-dispatch.html

[Radar WebKit Bug Importer]

<rdar://problem/58634315>

[WebKit Commit Bot]

The commit-queue just saw media/track/track-cues-sorted-before-dispatch.html flake (text diff) while processing attachment 387839 [details] on bug 206313.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

[WebKit Commit Bot]

Created attachment 387933 [details]
Archive of layout-test-results from webkit-cq-01

[Darin Adler]

I guess this flakiness is my fault, but not sure why.

[Eric Carlson]

(In reply to Darin Adler from comment #15)
> I guess this flakiness is my fault, but not sure why.

The test has always been flaky, your changes just make it flake more often. 

The test sometimes fails because TextTrackCue::isOrderedBefore only considers cue start and end time, so two cues with the same start time and duration will sort differently depending on their position in the red-black tree. 

The spec originally said to compare cues this way, but it later changed so cues in the same track with identical start/end times should sort by their order they were added to the track.

[Eric Carlson]

Created attachment 388072 [details]
Patch

[Jer Noble]

Comment on attachment 388072 [details]
Patch

LGTM; I think I understand what this change is doing. But please add some more comments to the changelog explaining what the problem was before and why this particular change was necessary.

[Eric Carlson]

Created attachment 388077 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 388077 [details]
Patch for landing

Clearing flags on attachment: 388077

Committed r254767: <https://trac.webkit.org/changeset/254767>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Nice.

[Alexey Proskuryakov]

*** Bug 168092 has been marked as a duplicate of this bug. ***

[Diego Pino]

*** Bug 210372 has been marked as a duplicate of this bug. ***