Bug 206233 – Offlineasm warnings with newer Ruby versions

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Adrian Perez]

Using Ruby 2.7 the following will be printed out:

  /home/aperez/WebKit/Source/JavaScriptCore/offlineasm/parser.rb:631:
  warning: deprecated Object#=~ is called on Annotation; it always returns nil

This is caused by the following change in Ruby:

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?revision=65989&view=revision

I see that the Annotation class does *not* define an overload for the =~ operator,
so previously applying it to an Annotation instance was already returning “nil”
(but silently).

Therefore I *think* that swapping the checks in the code to something like

  if @tokens[@idx].is_a? Annotation
     # ...
  elsif (@idx == @tokens.length and not final) or (final and @tokens[@idx] =~ final)
     # ...

should both silence the warning and still be correct.

Note that I do not have much experience with Ruby, nor with modifying offlineasm,
so suggestions are definitely welcome.

[Adrian Perez]

Created attachment 387655 [details]
Patch

[Adrian Perez]

The failed test run from the “mac-wk1” EWS seems unrelated.

[Yusuke Suzuki]

Comment on attachment 387655 [details]
Patch

r=me

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 387655 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 387655 [details]:

media/track/track-cues-sorted-before-dispatch.html bug 206225 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 387655 [details]
Patch

Clearing flags on attachment: 387655

Committed r254637: <https://trac.webkit.org/changeset/254637>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/58618860>