Bug 206288 - [LFC] Cache display box for the first LayoutState to Layout::Box
Summary: [LFC] Cache display box for the first LayoutState to Layout::Box
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-01-15 07:11 PST by Antti Koivisto
Modified: 2020-01-15 13:50 PST (History)
5 users (show)

See Also:

Attachments
patch (8.98 KB, patch)
2020-01-15 08:31 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-01-15 07:11:54 PST 
Add a single item cache for the common case to avoid using the hash.
Comment 1 Antti Koivisto 2020-01-15 08:31:37 PST 
Created attachment 387791 [details]
patch
Comment 2 zalan 2020-01-15 08:50:03 PST 
This pattern needs to be revisited when we start adding support for multiple LayoutStates such as printing, snapshots etc.
Comment 3 Antti Koivisto 2020-01-15 09:23:31 PST 
(In reply to zalan from comment #2)
> This pattern needs to be revisited when we start adding support for multiple
> LayoutStates such as printing, snapshots etc.

The pattern does work with multiple LayoutStates. It just only helps when there is 1.
Comment 4 zalan 2020-01-15 09:25:14 PST 
(In reply to Antti Koivisto from comment #3)
> (In reply to zalan from comment #2)
> > This pattern needs to be revisited when we start adding support for multiple
> > LayoutStates such as printing, snapshots etc.
> 
> The pattern does work with multiple LayoutStates. It just only helps when
> there is 1.
I guess I should have read it more carefully.
Comment 5 WebKit Commit Bot 2020-01-15 10:22:18 PST 
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2020-01-15 10:22:23 PST 
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]:

media/track/track-in-band-metadata-display-order.html bug 206226 (author: jer.noble@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2020-01-15 11:43:42 PST 
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]:

The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2020-01-15 11:44:02 PST 
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]:

media/track/track-cues-sorted-before-dispatch.html bug 206225 (authors: simon.pena@samsung.com and vcarbune@chromium.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2020-01-15 13:49:05 PST 
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2020-01-15 13:49:42 PST 
Comment on attachment 387791 [details]
patch

Clearing flags on attachment: 387791

Committed r254634: <https://trac.webkit.org/changeset/254634>
Comment 11 WebKit Commit Bot 2020-01-15 13:49:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2020-01-15 13:50:15 PST 
<rdar://problem/58617833>