RESOLVED FIXED 206288
[LFC] Cache display box for the first LayoutState to Layout::Box 
https://bugs.webkit.org/show_bug.cgi?id=206288
Summary [LFC] Cache display box for the first LayoutState to Layout::Box
Antti Koivisto
Reported 2020-01-15 07:11:54 PST
Add a single item cache for the common case to avoid using the hash.
Attachments
patch (8.98 KB, patch)
2020-01-15 08:31 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2020-01-15 08:31:37 PST
Created attachment 387791 [details] patch
zalan
Comment 2 2020-01-15 08:50:03 PST
This pattern needs to be revisited when we start adding support for multiple LayoutStates such as printing, snapshots etc.
Antti Koivisto
Comment 3 2020-01-15 09:23:31 PST
(In reply to zalan from comment #2) > This pattern needs to be revisited when we start adding support for multiple > LayoutStates such as printing, snapshots etc. The pattern does work with multiple LayoutStates. It just only helps when there is 1.
zalan
Comment 4 2020-01-15 09:25:14 PST
(In reply to Antti Koivisto from comment #3) > (In reply to zalan from comment #2) > > This pattern needs to be revisited when we start adding support for multiple > > LayoutStates such as printing, snapshots etc. > > The pattern does work with multiple LayoutStates. It just only helps when > there is 1. I guess I should have read it more carefully.
WebKit Commit Bot
Comment 5 2020-01-15 10:22:18 PST
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-01-15 10:22:23 PST
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]: media/track/track-in-band-metadata-display-order.html bug 206226 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-01-15 11:43:42 PST
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2020-01-15 11:44:02 PST
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]: media/track/track-cues-sorted-before-dispatch.html bug 206225 (authors: simon.pena@samsung.com and vcarbune@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2020-01-15 13:49:05 PST
The commit-queue encountered the following flaky tests while processing attachment 387791 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 10 2020-01-15 13:49:42 PST
Comment on attachment 387791 [details] patch Clearing flags on attachment: 387791 Committed r254634: <https://trac.webkit.org/changeset/254634>
WebKit Commit Bot
Comment 11 2020-01-15 13:49:44 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 12 2020-01-15 13:50:15 PST
<rdar://problem/58617833>
Note You need to log in before you can comment on or make changes to this bug.