Bug 201188 – Flaky Test: fullscreen/full-screen-request-removed-with-raf.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[WebKit Commit Bot]

This is an automatically generated bug from the commit-queue.
fullscreen/full-screen-request-removed-with-raf.html has been flaky on the commit-queue.

fullscreen/full-screen-request-removed-with-raf.html was authored by [e-mail].
https://trac.webkit.org/browser/trunk/LayoutTests/fullscreen/full-screen-request-removed-with-raf.html

The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377343 [details] on bug 201182.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

The bots will update this with information from each new failure.

If you believe this bug to be fixed or invalid, feel free to close.  The bots will re-open if the flake re-occurs.

If you would like to track this test fix with another bug, please close this bug as a duplicate.  The bots will follow the duplicate chain when making future comments.

[WebKit Commit Bot]

Created attachment 377352 [details]
Archive of layout-test-results from webkit-cq-03

[Jer Noble]

Aha, it looks like there's the possibility that 'webkitfullscreenchange' can fire before the first call to rAF(). We may need to re-write the test to not fail if this occurs.

[WebKit Commit Bot]

The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377341 [details] on bug 201181.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 377363 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377350 [details] on bug 201187.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 377365 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377283 [details] on bug 201152.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 377368 [details]
Archive of layout-test-results from webkit-cq-03

[Ryan Haddad]

This is a new test added with <https://trac.webkit.org/changeset/249147>

[Ryan Haddad]

--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fullscreen/full-screen-request-removed-with-raf-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fullscreen/full-screen-request-removed-with-raf-actual.txt
@@ -1,7 +1,6 @@
 Tests that fullscreen is not entered if the fullscreen element ancestor is removed with rAF while entering fullscreen.
 
-Removed child element.
-
+Fullscreen target!
 SUCCESS
 END OF TEST

[Jer Noble]

Created attachment 377378 [details]
Patch

[WebKit Commit Bot]

The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377301 [details] on bug 201165.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 377382 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377360 [details] on bug 201163.
Bot: webkit-cq-03  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 377387 [details]
Archive of layout-test-results from webkit-cq-03

[WebKit Commit Bot]

The commit-queue just saw fullscreen/full-screen-request-removed-with-raf.html flake (text diff) while processing attachment 377356 [details] on bug 201191.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Created attachment 377419 [details]
Archive of layout-test-results from webkit-cq-01

[WebKit Commit Bot]

Comment on attachment 377378 [details]
Patch

Clearing flags on attachment: 377378

Committed r249201: <https://trac.webkit.org/changeset/249201>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/54793843>